From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v6] libxl: introduce LIBXL_DOMAIN_TYPE_INVALID Date: Thu, 07 Jun 2012 09:18:13 +0200 Message-ID: <1339053493.8123.6.camel@Solace> References: <78af912f1823442009ea.1338990124@Solace> <1338994758.32319.130.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0968006088060031120==" Return-path: In-Reply-To: <1338994758.32319.130.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Christoph Egger , Roger Pau Monne , Ian Jackson , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org --===============0968006088060031120== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-IuHoQ8kt1/Pq7Ghz2i6X" --=-IuHoQ8kt1/Pq7Ghz2i6X Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2012-06-06 at 15:59 +0100, Ian Campbell wrote: > On Wed, 2012-06-06 at 14:42 +0100, Dario Faggioli wrote: > > To avoid recent gcc complaining about: > > libxl.c: In function 'libxl_primary_console_exec': > > libxl.c:1233:9: error: case value '4294967295' not in enumerated type '= libxl_domain_type' [-Werror=3Dswitch] > >=20 > > Also: > > - have all the call sites of libxl__domain_type() return with error in > > case the function returns LIBXL_DOMAIN_TYPE_INVALID; > > - adjust all other code segments where -Wswitch makes would claim that > > LIBXL_DOMAIN_TYPE_INVALID is not handled by adding a "default: abort= ();" > > clause. > >=20 > > Signed-off-by: Dario Faggioli > > Signed-off-by: Christoph Egger >=20 > Committed with the two changes I mentioned. Please check I haven't made > a mess of things... >=20 I looked at it and it seems fine. Thanks for doing this, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-IuHoQ8kt1/Pq7Ghz2i6X Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEABECAAYFAk/QVbUACgkQk4XaBE3IOsSFXACdEvG7OXAD2WjYzKn9XoxhZUqr P9MAmwQHRzB6WVFuZF0uvrs06By45ClG =PdAK -----END PGP SIGNATURE----- --=-IuHoQ8kt1/Pq7Ghz2i6X-- --===============0968006088060031120== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============0968006088060031120==--