From: Michael Ellerman <michael@ellerman.id.au>
To: Haren Myneni <haren@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, anton@samba.org
Subject: Re: [PATCH] Disable /dev/port interface on powerpc systems
Date: Fri, 08 Jun 2012 12:00:42 +1000 [thread overview]
Message-ID: <1339120842.3330.2.camel@concordia> (raw)
In-Reply-To: <1332577383.19329.5.camel@hbabu-laptop>
On Sat, 2012-03-24 at 01:23 -0700, Haren Myneni wrote:
> Ben, Here it is the updated patch based on your suggestions. Please let
> me know if it has any issues.
>
This breaks the i386 defconfig build with:
drivers/char/mem.c:903:3: error: implicit declaration of function
'arch_has_dev_port' [-Werror=implicit-function-declaration]
I think because that file includes <asm/io.h> directly, not via
include/linux/io.h, so your stub is never seen.
cheers
next prev parent reply other threads:[~2012-06-08 2:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 5:37 [PATCH] Disable /dev/port interface on powerpc systems Haren Myneni
2012-03-21 7:23 ` Benjamin Herrenschmidt
2012-03-21 18:58 ` Haren Myneni
2012-03-21 20:48 ` Benjamin Herrenschmidt
2012-03-24 8:23 ` Haren Myneni
2012-06-08 2:00 ` Michael Ellerman [this message]
2012-04-30 5:00 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2012-06-16 6:42 Haren Myneni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339120842.3330.2.camel@concordia \
--to=michael@ellerman.id.au \
--cc=anton@samba.org \
--cc=haren@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.