From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Andrew Wagin <avagin@gmail.com>
Cc: Arun Sharma <asharma@fb.com>, Oleg Strikov <OSTRIKOV@nvidia.com>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] [PATCH 0/5] Teach perf tool to profile sleep times (V4)
Date: Tue, 12 Jun 2012 19:46:04 +0200 [thread overview]
Message-ID: <1339523164.31548.103.camel@twins> (raw)
In-Reply-To: <CANaxB-xZ+KDZGMb8G1s5q+R_jzdWbP_FFxiGR=s4L90_tUqNjQ@mail.gmail.com>
On Tue, 2012-06-12 at 17:15 +0400, Andrew Wagin wrote:
> Yes, I like it. Are you going to commit this?
No its unfinished and untested.. not even sure its seen a compiler.
Also, in another email I wrote:
> Also, you don't need the callchain on the wakeup side of things. You
> only want the callchain of the sched_switch site.
>
> We could even dis-allow the callchain unwind when event->ctx->task &&
> event->ctx->task != current -- pretend the unwind failed by writing 0
> entries.
>
> That also avoids the 'difficultly' of exposing and trying to interpret
> another task's callchain.
That probably wants to be done as well.
If you have the time, please look into this. Hoping of course Frederic
and others don't object to this.. :-)
next prev parent reply other threads:[~2012-06-12 17:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 8:09 [RFC] [PATCH 0/5] Teach perf tool to profile sleep times (V4) Andrew Vagin
2012-06-04 8:09 ` [PATCH 1/5] sched: event: add trace events when a task starts executing on a cpu Andrew Vagin
2012-06-04 8:09 ` [PATCH 2/5] sched: send the event sched_switch before perf_event_task_sched_out Andrew Vagin
2012-06-04 8:09 ` [PATCH 3/5] sched: save a previous state on task_struct Andrew Vagin
2012-06-04 8:09 ` [PATCH 4/5] perf: teach "perf inject" to work with files Andrew Vagin
2012-06-04 8:09 ` [PATCH 5/5] perf: teach perf inject to merge sched_switch* events for profiling sleep times Andrew Vagin
2012-06-04 12:40 ` [RFC] [PATCH 0/5] Teach perf tool to profile sleep times (V4) Peter Zijlstra
2012-06-04 12:50 ` Peter Zijlstra
2012-06-04 13:46 ` Steven Rostedt
2012-06-04 17:01 ` Arun Sharma
2012-06-04 20:52 ` Peter Zijlstra
2012-06-06 8:32 ` Ingo Molnar
2012-06-12 13:15 ` Andrew Wagin
2012-06-12 17:46 ` Peter Zijlstra [this message]
2012-06-04 17:03 ` Arun Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339523164.31548.103.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=OSTRIKOV@nvidia.com \
--cc=asharma@fb.com \
--cc=avagin@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.