From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wanpeng Li Subject: [PATCH 6/7][TRIVIAL][resend] mm: cleanup page reclaim comment error Date: Fri, 15 Jun 2012 21:19:45 +0800 Message-ID: <1339766387-7740-1-git-send-email-liwp.linux@gmail.com> Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=0/bTixQ/iPv1uQayUR7dw+SWYPQgWW1qnB1S4FO1e/o=; b=g+HuGF5hvzRpYDqRhIB2KtyhoCRRh7qnyNqGD3jpk/As94rc7d4/sNRq0Bo6JsZ0Xm VMbqIsVyijVyB9/FuqdDKsRMXBDeIZuQLpyyhfzFCeGOAYQ1SqKYm+p3MpYp97fMbzxz UHLPYngFsIC7jOllPm8gl7cYxGWMJu7ZBBJA0S2WMwLacbx589pe5MIS7yC5zBLPBP7h nD+0mTcas6mvqL21neSxe0q3+lOBLG2sAS1KrLP+8l+g0m0jDhAmhGVYtZ7MMdx6zltb 0CpxoOhLcpO4OG0VNbM4miKmv/Rzdco1N9Wr1Zw0KlCppUE7VUeuq+IL5erLjXpLvAFF HXtA== Sender: owner-linux-mm@kvack.org List-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: trivial@kernel.org Cc: Benjamin Herrenschmidt , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Bjorn Helgaas , Johannes Weiner , Michal Hocko , Balbir Singh , KAMEZAWA Hiroyuki , Tejun Heo , Li Zefan , Christoph Lameter , Paul Gortmaker , Jesse Barnes , Milton Miller , Nishanth Aravamudan , Stephen Rothwell , Peter Zijlstra , Jason Wessel , Jan Kiszka , David Howells , Srikar Dronamraju From: Wanpeng Li Since there are five lists in LRU cache, the array nr in get_scan_count should be: nr[0] = anon inactive pages to scan; nr[1] = anon active pages to scan nr[2] = file inactive pages to scan; nr[3] = file active pages to scan Signed-off-by: Wanpeng Li Acked-by: KOSAKI Motohiro Acked-by: Minchan Kim Reviewed-by: Rik van Riel --- mm/vmscan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index eeb3bc9..ed823df 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1567,7 +1567,8 @@ static int vmscan_swappiness(struct scan_control *sc) * by looking at the fraction of the pages scanned we did rotate back * onto the active list instead of evict. * - * nr[0] = anon pages to scan; nr[1] = file pages to scan + * nr[0] = anon inactive pages to scan; nr[1] = anon active pages to scan + * nr[2] = file inactive pages to scan; nr[3] = file active pages to scan */ static void get_scan_count(struct lruvec *lruvec, struct scan_control *sc, unsigned long *nr) -- 1.7.9.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pb0-f51.google.com (mail-pb0-f51.google.com [209.85.160.51]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id B1CAEB70AE for ; Fri, 15 Jun 2012 23:20:19 +1000 (EST) Received: by pbbrp16 with SMTP id rp16so5983051pbb.38 for ; Fri, 15 Jun 2012 06:20:17 -0700 (PDT) From: Wanpeng Li To: trivial@kernel.org Subject: [PATCH 6/7][TRIVIAL][resend] mm: cleanup page reclaim comment error Date: Fri, 15 Jun 2012 21:19:45 +0800 Message-Id: <1339766387-7740-1-git-send-email-liwp.linux@gmail.com> Cc: Christoph Lameter , Srikar Dronamraju , linux-pci@vger.kernel.org, Jesse Barnes , David Howells , Paul Gortmaker , "H. Peter Anvin" , Larry Woodman , Andrea Arcangeli , Stephen Rothwell , Gavin Shan , x86@kernel.org, Hugh Dickins , Ingo Molnar , KOSAKI Motohiro , Jan Kiszka , Nishanth Aravamudan , Wanpeng Li , Peter Zijlstra , Mel Gorman , Jason Wessel , Al Viro , Bjorn Helgaas , cgroups@vger.kernel.org, Thomas Gleixner , KAMEZAWA Hiroyuki , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Milton Miller , Minchan Kim , Li Zefan , Johannes Weiner , Tejun Heo , David Rientjes , Andrew Morton , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Wanpeng Li Since there are five lists in LRU cache, the array nr in get_scan_count should be: nr[0] = anon inactive pages to scan; nr[1] = anon active pages to scan nr[2] = file inactive pages to scan; nr[3] = file active pages to scan Signed-off-by: Wanpeng Li Acked-by: KOSAKI Motohiro Acked-by: Minchan Kim Reviewed-by: Rik van Riel --- mm/vmscan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index eeb3bc9..ed823df 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1567,7 +1567,8 @@ static int vmscan_swappiness(struct scan_control *sc) * by looking at the fraction of the pages scanned we did rotate back * onto the active list instead of evict. * - * nr[0] = anon pages to scan; nr[1] = file pages to scan + * nr[0] = anon inactive pages to scan; nr[1] = anon active pages to scan + * nr[2] = file inactive pages to scan; nr[3] = file active pages to scan */ static void get_scan_count(struct lruvec *lruvec, struct scan_control *sc, unsigned long *nr) -- 1.7.9.5 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx114.postini.com [74.125.245.114]) by kanga.kvack.org (Postfix) with SMTP id 580336B0099 for ; Fri, 15 Jun 2012 09:20:18 -0400 (EDT) Received: by dakp5 with SMTP id p5so4954312dak.14 for ; Fri, 15 Jun 2012 06:20:17 -0700 (PDT) From: Wanpeng Li Subject: [PATCH 6/7][TRIVIAL][resend] mm: cleanup page reclaim comment error Date: Fri, 15 Jun 2012 21:19:45 +0800 Message-Id: <1339766387-7740-1-git-send-email-liwp.linux@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: trivial@kernel.org Cc: Benjamin Herrenschmidt , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Bjorn Helgaas , Johannes Weiner , Michal Hocko , Balbir Singh , KAMEZAWA Hiroyuki , Tejun Heo , Li Zefan , Christoph Lameter , Paul Gortmaker , Jesse Barnes , Milton Miller , Nishanth Aravamudan , Stephen Rothwell , Peter Zijlstra , Jason Wessel , Jan Kiszka , David Howells , Srikar Dronamraju , Andrew Morton , Mel Gorman , Minchan Kim , Gavin Shan , Al Viro , Andrea Arcangeli , David Rientjes , KOSAKI Motohiro , Larry Woodman , Hugh Dickins , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, Wanpeng Li From: Wanpeng Li Since there are five lists in LRU cache, the array nr in get_scan_count should be: nr[0] = anon inactive pages to scan; nr[1] = anon active pages to scan nr[2] = file inactive pages to scan; nr[3] = file active pages to scan Signed-off-by: Wanpeng Li Acked-by: KOSAKI Motohiro Acked-by: Minchan Kim Reviewed-by: Rik van Riel --- mm/vmscan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index eeb3bc9..ed823df 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1567,7 +1567,8 @@ static int vmscan_swappiness(struct scan_control *sc) * by looking at the fraction of the pages scanned we did rotate back * onto the active list instead of evict. * - * nr[0] = anon pages to scan; nr[1] = file pages to scan + * nr[0] = anon inactive pages to scan; nr[1] = anon active pages to scan + * nr[2] = file inactive pages to scan; nr[3] = file active pages to scan */ static void get_scan_count(struct lruvec *lruvec, struct scan_control *sc, unsigned long *nr) -- 1.7.9.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org