From: Peter Zijlstra <peterz@infradead.org>
To: mingo@kernel.org
Cc: pjt@google.com, venki@google.com, efault@gmx.de,
rostedt@goodmis.org, glommer@parallels.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 4/4] sched/fair: Optimize cgroup pick_next_task_fair
Date: Fri, 15 Jun 2012 16:03:19 +0200 [thread overview]
Message-ID: <1339768999.2559.69.camel@twins> (raw)
In-Reply-To: <1339708758.2559.42.camel@twins>
On Thu, 2012-06-14 at 23:19 +0200, Peter Zijlstra wrote:
> On Thu, 2012-06-14 at 15:29 +0200, Peter Zijlstra wrote:
> > Since commit 2f36825b1 ("sched: Next buddy hint on sleep and preempt
> > path") it is likely we pick a new task from the same cgroup, doing a put
> > and then set on all intermediate entities is a waste of time, so try to
> > avoid this.
>
> I just noticed put_prev_entity() also does the bandwidth enforcement
> stuff, I think I just broke that. Will have a peek at fixing that
> tomorrow or so.
Damn, that's annoying, that wants to be done bottom-up, while we're now
doing a top-down selection. pjt any sane ideas?
next prev parent reply other threads:[~2012-06-15 14:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 13:29 [RFC][PATCH 0/4] sched: Optimize cgroup muck Peter Zijlstra
2012-06-14 13:29 ` [RFC][PATCH 1/4] sched/fair: track cgroup depth Peter Zijlstra
2012-06-14 13:29 ` [RFC][PATCH 2/4] sched: Push put_prev_task() into pick_next_task() Peter Zijlstra
2012-06-14 14:32 ` Steven Rostedt
2012-06-14 14:58 ` Peter Zijlstra
2012-06-15 9:49 ` Glauber Costa
2012-06-15 10:03 ` Peter Zijlstra
2012-06-15 10:01 ` Glauber Costa
2012-06-21 7:35 ` Michael Wang
2012-06-21 8:41 ` Peter Zijlstra
2012-06-21 9:23 ` Michael Wang
2012-06-14 13:29 ` [RFC][PATCH 3/4] sched/fair: clean up __clear_buddies_* Peter Zijlstra
2012-06-14 13:29 ` [RFC][PATCH 4/4] sched/fair: Optimize cgroup pick_next_task_fair Peter Zijlstra
2012-06-14 21:19 ` Peter Zijlstra
2012-06-15 14:03 ` Peter Zijlstra [this message]
2012-06-19 8:45 ` Paul Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339768999.2559.69.camel@twins \
--to=peterz@infradead.org \
--cc=efault@gmx.de \
--cc=glommer@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pjt@google.com \
--cc=rostedt@goodmis.org \
--cc=venki@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.