From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wanpeng Li Subject: [PATCH] mm/memcg: add unlikely to mercg->move_charge_at_immigrate Date: Mon, 18 Jun 2012 21:10:21 +0800 Message-ID: <1340025022-7272-1-git-send-email-liwp.linux@gmail.com> Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=cvh+5MBpYBHsPoqdJjQ41Bl8ey1g9wIyPbXLGHU+QgA=; b=xmMD8x5bL/pTJmhYFJjhrLTwsJhYUsmSOccG2YUt9jnxSLZcbX6Brm7vGvfTCUMRtQ R3YYdKEqiTOMZwMDSigb7Y0RtfOrUO9L3CzuEtNtE6KfbkTTtBmlsTkS1HMR9ELT6ZQX c/UelcWAZahgtPubMU22B3J6N5vpq2Emim37v9Wm2B0EpOCgiUMwF3gyvQFfMbJln0rk T62iQaGCsHJA9dE8Oqd6XnuJ4hQlGba7UAUom65y3tg+m1A1w4fpS5j2gbOED6cHp+Pw jbKRCSIVHZzREmDXdyJohGY1QyIBV/yszqlDRpxId0meRA6QKICfoHeND43xQPKaj191 YPVQ== Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Johannes Weiner , Michal Hocko , Balbir Singh , KAMEZAWA Hiroyuki Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Gavin Shan , Wanpeng Li From: Wanpeng Li move_charge_at_immigrate feature is disabled by default. Charges are moved only when you move mm->owner and it also add additional overhead. Signed-off-by: Wanpeng Li --- mm/memcontrol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index a9c3d01..795a00f 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -5316,7 +5316,7 @@ static int mem_cgroup_can_attach(struct cgroup *cgroup, int ret = 0; struct mem_cgroup *memcg = mem_cgroup_from_cont(cgroup); - if (memcg->move_charge_at_immigrate) { + if (unlikely(memcg->move_charge_at_immigrate)) { struct mm_struct *mm; struct mem_cgroup *from = mem_cgroup_from_task(p); -- 1.7.9.5 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx143.postini.com [74.125.245.143]) by kanga.kvack.org (Postfix) with SMTP id ACCF96B004D for ; Mon, 18 Jun 2012 09:10:43 -0400 (EDT) Received: by dakp5 with SMTP id p5so8617706dak.14 for ; Mon, 18 Jun 2012 06:10:42 -0700 (PDT) From: Wanpeng Li Subject: [PATCH] mm/memcg: add unlikely to mercg->move_charge_at_immigrate Date: Mon, 18 Jun 2012 21:10:21 +0800 Message-Id: <1340025022-7272-1-git-send-email-liwp.linux@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: Johannes Weiner , Michal Hocko , Balbir Singh , KAMEZAWA Hiroyuki Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Gavin Shan , Wanpeng Li From: Wanpeng Li move_charge_at_immigrate feature is disabled by default. Charges are moved only when you move mm->owner and it also add additional overhead. Signed-off-by: Wanpeng Li --- mm/memcontrol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index a9c3d01..795a00f 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -5316,7 +5316,7 @@ static int mem_cgroup_can_attach(struct cgroup *cgroup, int ret = 0; struct mem_cgroup *memcg = mem_cgroup_from_cont(cgroup); - if (memcg->move_charge_at_immigrate) { + if (unlikely(memcg->move_charge_at_immigrate)) { struct mm_struct *mm; struct mem_cgroup *from = mem_cgroup_from_task(p); -- 1.7.9.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751864Ab2FRNKo (ORCPT ); Mon, 18 Jun 2012 09:10:44 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:63022 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992Ab2FRNKn (ORCPT ); Mon, 18 Jun 2012 09:10:43 -0400 From: Wanpeng Li To: Johannes Weiner , Michal Hocko , Balbir Singh , KAMEZAWA Hiroyuki Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Gavin Shan , Wanpeng Li Subject: [PATCH] mm/memcg: add unlikely to mercg->move_charge_at_immigrate Date: Mon, 18 Jun 2012 21:10:21 +0800 Message-Id: <1340025022-7272-1-git-send-email-liwp.linux@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wanpeng Li move_charge_at_immigrate feature is disabled by default. Charges are moved only when you move mm->owner and it also add additional overhead. Signed-off-by: Wanpeng Li --- mm/memcontrol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index a9c3d01..795a00f 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -5316,7 +5316,7 @@ static int mem_cgroup_can_attach(struct cgroup *cgroup, int ret = 0; struct mem_cgroup *memcg = mem_cgroup_from_cont(cgroup); - if (memcg->move_charge_at_immigrate) { + if (unlikely(memcg->move_charge_at_immigrate)) { struct mm_struct *mm; struct mem_cgroup *from = mem_cgroup_from_task(p); -- 1.7.9.5