All of lore.kernel.org
 help / color / mirror / Atom feed
From: zwu.kernel@gmail.com
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, aliguori@us.ibm.com,
	Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>,
	stefanha@linux.vnet.ibm.com, jan.kiszka@siemens.com
Subject: [Qemu-devel] [PATCH v5 09/17] net: Rename non_vlan_clients to net_clients
Date: Tue, 19 Jun 2012 00:59:11 +0800	[thread overview]
Message-ID: <1340038759-27796-10-git-send-email-zwu.kernel@gmail.com> (raw)
In-Reply-To: <1340038759-27796-1-git-send-email-zwu.kernel@gmail.com>

From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

There is no longer a distinction between vlan clients and non-vlan
clients in the net core.  The net core only knows about point-to-point
clients which are connected to a peer.  It's time to rename the global
list of net clients since it no longer refers to vlans at all.

Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
---
 net.c |   20 ++++++++++----------
 1 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/net.c b/net.c
index 73325b0..d3a685e 100644
--- a/net.c
+++ b/net.c
@@ -44,7 +44,7 @@
 # define CONFIG_NET_BRIDGE
 #endif
 
-static QTAILQ_HEAD(, VLANClientState) non_vlan_clients;
+static QTAILQ_HEAD(, VLANClientState) net_clients;
 
 int default_net = 1;
 
@@ -165,7 +165,7 @@ static char *assign_name(VLANClientState *vc1, const char *model)
     char buf[256];
     int id = 0;
 
-    QTAILQ_FOREACH(vc, &non_vlan_clients, next) {
+    QTAILQ_FOREACH(vc, &net_clients, next) {
         if (vc == vc1) {
             continue;
         }
@@ -216,7 +216,7 @@ VLANClientState *qemu_new_net_client(NetClientInfo *info,
         vc->peer = peer;
         peer->peer = vc;
     }
-    QTAILQ_INSERT_TAIL(&non_vlan_clients, vc, next);
+    QTAILQ_INSERT_TAIL(&net_clients, vc, next);
 
     vc->send_queue = qemu_new_net_queue(qemu_deliver_packet,
                                         qemu_deliver_packet_iov,
@@ -248,7 +248,7 @@ NICState *qemu_new_nic(NetClientInfo *info,
 
 static void qemu_cleanup_vlan_client(VLANClientState *vc)
 {
-    QTAILQ_REMOVE(&non_vlan_clients, vc, next);
+    QTAILQ_REMOVE(&net_clients, vc, next);
 
     if (vc->info->cleanup) {
         vc->info->cleanup(vc);
@@ -302,7 +302,7 @@ void qemu_foreach_nic(qemu_nic_foreach func, void *opaque)
 {
     VLANClientState *nc;
 
-    QTAILQ_FOREACH(nc, &non_vlan_clients, next) {
+    QTAILQ_FOREACH(nc, &net_clients, next) {
         if (nc->info->type == NET_CLIENT_TYPE_NIC) {
             func(DO_UPCAST(NICState, nc, nc), opaque);
         }
@@ -467,7 +467,7 @@ VLANClientState *qemu_find_netdev(const char *id)
 {
     VLANClientState *vc;
 
-    QTAILQ_FOREACH(vc, &non_vlan_clients, next) {
+    QTAILQ_FOREACH(vc, &net_clients, next) {
         if (vc->info->type == NET_CLIENT_TYPE_NIC)
             continue;
         if (!strcmp(vc->name, id)) {
@@ -1099,7 +1099,7 @@ void do_info_network(Monitor *mon)
     net_client_type type;
 
     monitor_printf(mon, "Devices not on any VLAN:\n");
-    QTAILQ_FOREACH(vc, &non_vlan_clients, next) {
+    QTAILQ_FOREACH(vc, &net_clients, next) {
         peer = vc->peer;
         type = vc->info->type;
         if (!peer || type == NET_CLIENT_TYPE_NIC) {
@@ -1152,7 +1152,7 @@ void net_cleanup(void)
 {
     VLANClientState *vc, *next_vc;
 
-    QTAILQ_FOREACH_SAFE(vc, &non_vlan_clients, next, next_vc) {
+    QTAILQ_FOREACH_SAFE(vc, &net_clients, next, next_vc) {
         qemu_del_vlan_client(vc);
     }
 }
@@ -1176,7 +1176,7 @@ void net_check_clients(void)
 
     net_hub_check_clients();
 
-    QTAILQ_FOREACH(vc, &non_vlan_clients, next) {
+    QTAILQ_FOREACH(vc, &net_clients, next) {
         if (!vc->peer) {
             fprintf(stderr, "Warning: %s %s has no peer\n",
                     vc->info->type == NET_CLIENT_TYPE_NIC ? "nic" : "netdev",
@@ -1240,7 +1240,7 @@ int net_init_clients(void)
 #endif
     }
 
-    QTAILQ_INIT(&non_vlan_clients);
+    QTAILQ_INIT(&net_clients);
 
     if (qemu_opts_foreach(qemu_find_opts("netdev"), net_init_netdev, NULL, 1) == -1)
         return -1;
-- 
1.7.6

  parent reply	other threads:[~2012-06-18 17:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-18 16:59 [Qemu-devel] [PATCH v5 00/17] hub-based networking patches zwu.kernel
2012-06-18 16:59 ` [Qemu-devel] [PATCH v5 01/17] net: Add a hub net client zwu.kernel
2012-06-18 16:59 ` [Qemu-devel] [PATCH v5 02/17] net: Use hubs for the vlan feature zwu.kernel
2012-06-18 16:59 ` [Qemu-devel] [PATCH v5 03/17] net: Look up 'vlan' net clients using hubs zwu.kernel
2012-06-18 16:59 ` [Qemu-devel] [PATCH v5 04/17] hub: Check that hubs are configured correctly zwu.kernel
2012-06-18 16:59 ` [Qemu-devel] [PATCH v5 05/17] net: Drop vlan argument to qemu_new_net_client() zwu.kernel
2012-06-18 16:59 ` [Qemu-devel] [PATCH v5 06/17] net: Remove vlan qdev property zwu.kernel
2012-06-18 16:59 ` [Qemu-devel] [PATCH v5 07/17] net: Remove vlan code from net.c zwu.kernel
2012-06-18 16:59 ` [Qemu-devel] [PATCH v5 08/17] net: Remove VLANState zwu.kernel
2012-06-18 16:59 ` zwu.kernel [this message]
2012-06-18 16:59 ` [Qemu-devel] [PATCH v5 10/17] net: Rename VLANClientState to NetClientState zwu.kernel
2012-06-19 18:36   ` Anthony Liguori
2012-06-19 22:14     ` Zhi Yong Wu
2012-06-18 16:59 ` [Qemu-devel] [PATCH v5 11/17] net: Rename vc local variables to nc zwu.kernel
2012-06-18 16:59 ` [Qemu-devel] [PATCH v5 12/17] net: Rename qemu_del_vlan_client() to qemu_del_net_client() zwu.kernel
2012-06-18 16:59 ` [Qemu-devel] [PATCH v5 13/17] net: Make "info network" output more readable info zwu.kernel
2012-06-18 16:59 ` [Qemu-devel] [PATCH v5 14/17] net: cleanup deliver/deliver_iov func pointers zwu.kernel
2012-06-18 16:59 ` [Qemu-devel] [PATCH v5 15/17] net: determine if packets can be sent before net queue deliver packets zwu.kernel
2012-06-18 16:59 ` [Qemu-devel] [PATCH v5 16/17] hub: add the support for hub own flow control zwu.kernel
2012-06-18 16:59 ` [Qemu-devel] [PATCH v5 17/17] net: roll back qdev_prop_vlan zwu.kernel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340038759-27796-10-git-send-email-zwu.kernel@gmail.com \
    --to=zwu.kernel@gmail.com \
    --cc=aliguori@us.ibm.com \
    --cc=jan.kiszka@siemens.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    --cc=wuzhy@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.