From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: fsimage - no such file
Date: Tue, 19 Jun 2012 17:36:04 +0100
Message-ID: <1340123764.24176.50.camel@zakaz.uk.xensource.com>
References: <CABA5EEuVTVOHSPD6j1TvHivL8wtmS=NudAL=5wcQOm99qPPvBw@mail.gmail.com>
	<4B45B535F7F6BE4CB1C044ED5115CDDEED66156583@LONPMAILBOX01.citrite.net>
	<1340103453.24176.7.camel@zakaz.uk.xensource.com>
	<CABA5EEtD32O+M2yA=WiHuGvBv0oF=VRd7WnisvpnHuau40Qj3Q@mail.gmail.com>
	<20120619161039.GB4296@US-SEA-R8XVZTX>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20120619161039.GB4296@US-SEA-R8XVZTX>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Matt Wilson <msw@amazon.com>
Cc: Mohammad Hedayati <hedayati.mo@gmail.com>, Thanos Makatos <thanos.makatos@citrix.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Roger Pau Monne <roger.pau@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2012-06-19 at 17:10 +0100, Matt Wilson wrote:
> On Tue, Jun 19, 2012 at 04:19:27AM -0700, Mohammad Hedayati wrote:
> > > # Node ID 6eabee6807b48c72bcc35a28170f0729500def85
> > > # Parent  80c0677f0f8370a4542aab81ab93380b0dab25db
> > > imported patch debian-lib-dir.patch
> > >
> > > diff -r 80c0677f0f83 -r 6eabee6807b4 config/StdGNU.mk
> > > --- a/config/StdGNU.mk  Wed Jun 13 09:27:53 2012 +0100
> > > +++ b/config/StdGNU.mk  Wed Jun 13 09:27:53 2012 +0100
> > > @@ -34,7 +34,7 @@ BINDIR = $(PREFIX)/bin
> > >  INCLUDEDIR = $(PREFIX)/include
> > >  LIBLEAFDIR = lib
> > >  LIBLEAFDIR_x86_32 = lib
> > > -LIBLEAFDIR_x86_64 ?= lib64
> > > +LIBLEAFDIR_x86_64 ?= lib
> > >  LIBDIR = $(PREFIX)/$(LIBLEAFDIR)
> > >  LIBDIR_x86_32 = $(PREFIX)/$(LIBLEAFDIR_x86_32)
> > >  LIBDIR_x86_64 = $(PREFIX)/$(LIBLEAFDIR_x86_64)
> > >
> > > Can you try a fresh build with this applied and see if that helps.
> > I have applied this patch. I think libfsimage is somehow not being
> > affected with this. Yet, linking /usr/lib64/fs -> /usr/lib/fs solves
> > the problem.
> 
> libfsimage is going to blindly look in /usr/lib64 on non-Itanium
> 64-bit Linux platforms. See tools/libfsimage/common/fsimage_plugin.c:134

Oh bloody hell, I hadn't spotted that.

We should definitely be setting FSIMAGE_FSDIR to something sane based on
LIBDIR and not letting all sorts of weird heuristics kick in.

Ian.

> 
> #if defined(FSIMAGE_FSDIR)
>         if (fsdir == NULL)
>                 fsdir = FSIMAGE_FSDIR;
> #elif defined(__sun__)
>         if (fsdir == NULL)
>                 fsdir = "/usr/lib/fs";
> 
>         if (sizeof(void *) == 8)
>                 isadir = "64/";
> #elif defined(__ia64__)
>         if (fsdir == NULL)
>                 fsdir = "/usr/lib/fs";
> #else
>         if (fsdir == NULL) {
>                 if (sizeof(void *) == 8)
>                         fsdir = "/usr/lib64/fs";
>                 else
>                         fsdir = "/usr/lib/fs";
>         }
> #endif
> 
> Matt