From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFCv2] respect channels in iface combinations
Date: Wed, 20 Jun 2012 10:23:08 +0200 [thread overview]
Message-ID: <1340180588.4655.26.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1340172859-18146-1-git-send-email-michal.kazior@tieto.com>
Hi Michal,
> I've addressed the issue with non-fixed channel IBSS.
> Channels are now cosidered either shared or exclusive. An
> exclusive channel always takes a channel resource (when
> accouting interface combinations and
> num_different_channels). Exclusive channel could also be
> called hopping but I thought the first one fits better as it
> explicitly states code logic decisions.
>
> I've also refactored and fixed interface combination
> checking. There are now functions like
> cfg80211_can_use_chan, cfg80211_can_use_iftype_chan.
>
> Monitor channel is now always defined. When there are
> only monitors running we set a channel (first we can find in
> supported bands structures). This way the corner case
> (of a monitor not having a channel and .get_channel
> returning NULL) mentioned by Johannes is fixed.
Thanks!
I've looked over it briefly and sent a few comments, but I still need to
look at patches 6, 10, 12 and 13 in more detail.
johannes
prev parent reply other threads:[~2012-06-20 8:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 6:14 [RFCv2] respect channels in iface combinations Michal Kazior
2012-06-20 6:14 ` [RFCv2 01/13] cfg80211: introduce cfg80211_stop_ap Michal Kazior
2012-06-20 6:14 ` [RFCv2 02/13] cfg80211: .stop_ap when interface is going down Michal Kazior
2012-06-20 6:14 ` [RFCv2 03/13] cfg80211: add channel tracking for AP and mesh Michal Kazior
2012-06-20 8:18 ` Johannes Berg
2012-06-20 9:03 ` Michal Kazior
2012-06-20 9:09 ` Johannes Berg
2012-06-20 6:14 ` [RFCv2 04/13] cfg80211: track ibss fixed channel Michal Kazior
2012-06-20 6:14 ` [RFCv2 05/13] cfg80211: introduce cfg80211_get_chan_state Michal Kazior
2012-06-20 8:19 ` Johannes Berg
2012-06-20 9:11 ` Michal Kazior
2012-06-20 9:13 ` Johannes Berg
2012-06-20 6:14 ` [RFCv2 06/13] cfg80211: track monitor interfaces count Michal Kazior
2012-06-21 14:55 ` Johannes Berg
2012-06-20 6:14 ` [RFCv2 07/13] mac80211: refactor virtual monitor code Michal Kazior
2012-06-20 6:14 ` [RFCv2 08/13] cfg80211: refuse to .set_monitor_channel when non-monitors are present Michal Kazior
2012-06-20 6:14 ` [RFCv2 09/13] cfg80211: track monitor channel Michal Kazior
2012-06-20 6:14 ` [RFCv2 10/13] cfg80211: set initial " Michal Kazior
2012-06-21 14:57 ` Johannes Berg
2012-06-25 6:57 ` Michal Kazior
2012-06-25 7:28 ` Johannes Berg
2012-06-25 7:40 ` Michal Kazior
2012-06-25 7:41 ` Johannes Berg
2012-06-20 6:14 ` [RFCv2 11/13] cfg80211/mac80211: remove .get_channel Michal Kazior
2012-06-20 6:14 ` [RFCv2 12/13] cfg80211: add channel checking for iface combinations Michal Kazior
2012-06-21 15:03 ` Johannes Berg
2012-06-25 7:00 ` Michal Kazior
2012-06-20 6:14 ` [RFCv2 13/13] cfg80211: respect iface combinations when starting operation Michal Kazior
2012-06-21 15:06 ` Johannes Berg
2012-06-25 7:05 ` Michal Kazior
2012-06-25 7:27 ` Johannes Berg
2012-06-20 8:23 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340180588.4655.26.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.