All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, aliguori@us.ibm.com,
	ehabkost@redhat.com, jan.kiszka@siemens.com, mtosatti@redhat.com,
	mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com,
	pbonzini@redhat.com, afaerber@suse.de
Subject: [Qemu-devel] [PATCH 1/5] target-i386: drop usage of prev_debug_excp_handler
Date: Wed, 20 Jun 2012 14:59:20 +0200	[thread overview]
Message-ID: <1340197164-9574-2-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1340197164-9574-1-git-send-email-imammedo@redhat.com>

Chain of exception handlers are currently unused feature, drop it
for now to avoid moving prev_debug_excp_handler variable at global
scope when moving tcg initialization into target-i386/cpu.c

Later we probably could re-invent better interface for this.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
 target-i386/helper.c |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/target-i386/helper.c b/target-i386/helper.c
index 2cc8097..b9384f6 100644
--- a/target-i386/helper.c
+++ b/target-i386/helper.c
@@ -941,8 +941,6 @@ int check_hw_breakpoints(CPUX86State *env, int force_dr6_update)
     return hit_enabled;
 }
 
-static CPUDebugExcpHandler *prev_debug_excp_handler;
-
 static void breakpoint_handler(CPUX86State *env)
 {
     CPUBreakpoint *bp;
@@ -965,8 +963,6 @@ static void breakpoint_handler(CPUX86State *env)
                 break;
             }
     }
-    if (prev_debug_excp_handler)
-        prev_debug_excp_handler(env);
 }
 
 typedef struct MCEInjectionParams {
@@ -1166,8 +1162,7 @@ X86CPU *cpu_x86_init(const char *cpu_model)
         inited = 1;
         optimize_flags_init();
 #ifndef CONFIG_USER_ONLY
-        prev_debug_excp_handler =
-            cpu_set_debug_excp_handler(breakpoint_handler);
+        cpu_set_debug_excp_handler(breakpoint_handler);
 #endif
     }
     if (cpu_x86_register(cpu, cpu_model) < 0) {
-- 
1.7.10.2

  reply	other threads:[~2012-06-20 12:59 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-20 12:59 [Qemu-devel] [PATCH 0/5] target-i386: move cpu reset and tcg intialization inside CPU object Igor Mammedov
2012-06-20 12:59 ` Igor Mammedov [this message]
2012-06-20 13:28   ` [Qemu-devel] [PATCH 1/5] target-i386: drop usage of prev_debug_excp_handler Jan Kiszka
2012-06-21  9:29     ` Igor Mammedov
2012-06-20 12:59 ` [Qemu-devel] [PATCH 2/5] target-i386: move tcg initialization into x86_cpu_initfn() Igor Mammedov
2012-06-20 13:17   ` Andreas Färber
2012-06-20 12:59 ` [Qemu-devel] [PATCH 3/5] target-i386: call x86_cpu_realize() after APIC is initialized Igor Mammedov
2012-06-20 13:35   ` Andreas Färber
2012-06-21  9:43     ` Igor Mammedov
2012-06-21 10:14       ` Andreas Färber
2012-06-21 11:59         ` Igor Mammedov
2012-07-09 10:59     ` igor
2012-07-09 12:57       ` Andreas Färber
2012-07-10 13:35         ` Igor Mammedov
2012-07-11  7:35           ` liu ping fan
2012-07-11 12:27             ` Igor Mammedov
2012-07-12  2:16               ` liu ping fan
2012-07-11  7:32         ` liu ping fan
2012-06-20 12:59 ` [Qemu-devel] [PATCH 4/5] target-i386: move cpu halted decision into x86_cpu_reset Igor Mammedov
2012-06-20 12:59 ` [Qemu-devel] [PATCH 5/5] target-i386: move cpu_reset and reset callback to cpu.c Igor Mammedov
2012-06-21 11:54   ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340197164-9574-2-git-send-email-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=ehabkost@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.