All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: openembedded-core <openembedded-core@lists.openembedded.org>
Subject: [PATCH] layer.conf/bblayers.conf.sample: Fix empth BBPATH entry warnings
Date: Fri, 22 Jun 2012 14:39:55 +0100	[thread overview]
Message-ID: <1340372395.394.35.camel@ted> (raw)

Many people are seeing issues from the empty path warnings from BBPATH.
The empty path entry corresponding to the current working directory is a
problem since if cwd changes, so does BBPATH and build reproducibility.

Simply removing the empty element causes problems since the build
directory then isn't listed in BBPATH which means local.conf isn't found
and this gives an extremely confusing error message about bbappends
being unsatisfied.

The build directory in bitbake terms is TOPDIR. The correct way to fix
things is to add in TOPDIR into bblayers.conf itself. This means the
layers can happily append/prepend to BBPATH at will as its no longer
empty hence neatly solving all the various problems. Since the file has
changed, the version is also changed.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

---
 meta/conf/bblayers.conf.sample |    4 +++-
 meta/conf/layer.conf           |    1 -
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/meta/conf/bblayers.conf.sample b/meta/conf/bblayers.conf.sample
index 222b03a..e621866 100644
--- a/meta/conf/bblayers.conf.sample
+++ b/meta/conf/bblayers.conf.sample
@@ -1,8 +1,10 @@
 # LAYER_CONF_VERSION is increased each time build/conf/bblayers.conf
 # changes incompatibly
-LCONF_VERSION = "4"
+LCONF_VERSION = "5"
 
+BBPATH = "${TOPDIR}"
 BBFILES ?= ""
+
 BBLAYERS ?= " \
   ##COREBASE##/meta \
   "
diff --git a/meta/conf/layer.conf b/meta/conf/layer.conf
index 43e4295..090c8e2 100644
--- a/meta/conf/layer.conf
+++ b/meta/conf/layer.conf
@@ -1,4 +1,3 @@
-BBPATH ?= ""
 # We have a conf and classes directory, add to BBPATH
 BBPATH .= ":${LAYERDIR}"
 # We have a packages directory, add to BBFILES




             reply	other threads:[~2012-06-22 13:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-22 13:39 Richard Purdie [this message]
2012-06-22 14:17 ` [PATCH] layer.conf/bblayers.conf.sample: Fix empth BBPATH entry warnings Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340372395.394.35.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.