All of lore.kernel.org
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 8/8] Revert "Revert "arm: remove unused restart trampoline""
Date: Fri, 22 Jun 2012 16:07:06 +0100	[thread overview]
Message-ID: <1340377626-17075-9-git-send-email-will.deacon@arm.com> (raw)
In-Reply-To: <1340377626-17075-1-git-send-email-will.deacon@arm.com>

This reverts commit b7913c74b230d2f4fbdb6928a099933bb15f8e49.

Now that we perform system call restarting in the kernel, we can safely
remove the OABI restart trampoline.

Signed-off-by: Will Deacon <will.deacon@arm.com>
---
 arch/arm/kernel/signal.c |   13 -------------
 arch/arm/kernel/signal.h |    2 --
 arch/arm/kernel/traps.c  |    2 --
 3 files changed, 0 insertions(+), 17 deletions(-)

diff --git a/arch/arm/kernel/signal.c b/arch/arm/kernel/signal.c
index 8250475..19b899f 100644
--- a/arch/arm/kernel/signal.c
+++ b/arch/arm/kernel/signal.c
@@ -28,7 +28,6 @@
  */
 #define SWI_SYS_SIGRETURN	(0xef000000|(__NR_sigreturn)|(__NR_OABI_SYSCALL_BASE))
 #define SWI_SYS_RT_SIGRETURN	(0xef000000|(__NR_rt_sigreturn)|(__NR_OABI_SYSCALL_BASE))
-#define SWI_SYS_RESTART		(0xef000000|__NR_restart_syscall|__NR_OABI_SYSCALL_BASE)
 
 /*
  * With EABI, the syscall number has to be loaded into r7.
@@ -49,18 +48,6 @@ const unsigned long sigreturn_codes[7] = {
 };
 
 /*
- * Either we support OABI only, or we have EABI with the OABI
- * compat layer enabled.  In the later case we don't know if
- * user space is EABI or not, and if not we must not clobber r7.
- * Always using the OABI syscall solves that issue and works for
- * all those cases.
- */
-const unsigned long syscall_restart_code[2] = {
-	SWI_SYS_RESTART,	/* swi	__NR_restart_syscall */
-	0xe49df004,		/* ldr	pc, [sp], #4 */
-};
-
-/*
  * atomically swap in the new signal mask, and wait for a signal.
  */
 asmlinkage int sys_sigsuspend(int restart, unsigned long oldmask, old_sigset_t mask)
diff --git a/arch/arm/kernel/signal.h b/arch/arm/kernel/signal.h
index 6fcfe83..5ff067b7 100644
--- a/arch/arm/kernel/signal.h
+++ b/arch/arm/kernel/signal.h
@@ -8,7 +8,5 @@
  * published by the Free Software Foundation.
  */
 #define KERN_SIGRETURN_CODE	(CONFIG_VECTORS_BASE + 0x00000500)
-#define KERN_RESTART_CODE	(KERN_SIGRETURN_CODE + sizeof(sigreturn_codes))
 
 extern const unsigned long sigreturn_codes[7];
-extern const unsigned long syscall_restart_code[2];
diff --git a/arch/arm/kernel/traps.c b/arch/arm/kernel/traps.c
index 3647170..4928d89 100644
--- a/arch/arm/kernel/traps.c
+++ b/arch/arm/kernel/traps.c
@@ -820,8 +820,6 @@ void __init early_trap_init(void *vectors_base)
 	 */
 	memcpy((void *)(vectors + KERN_SIGRETURN_CODE - CONFIG_VECTORS_BASE),
 	       sigreturn_codes, sizeof(sigreturn_codes));
-	memcpy((void *)(vectors + KERN_RESTART_CODE - CONFIG_VECTORS_BASE),
-	       syscall_restart_code, sizeof(syscall_restart_code));
 
 	flush_icache_range(vectors, vectors + PAGE_SIZE);
 	modify_domain(DOMAIN_USER, DOMAIN_CLIENT);
-- 
1.7.4.1

  parent reply	other threads:[~2012-06-22 15:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-22 15:06 [RFC PATCH 0/8] Fix restart_block syscall restarting for 3.5 Will Deacon
2012-06-22 15:06 ` [RFC PATCH 1/8] Revert "arm: remove unused restart trampoline" Will Deacon
2012-06-22 15:07 ` [RFC PATCH 2/8] Revert "arm: new way of handling ERESTART_RESTARTBLOCK" Will Deacon
2012-06-22 15:07 ` [RFC PATCH 3/8] audit: arm: only allow syscall auditing for pure EABI userspace Will Deacon
2012-06-22 15:07 ` [RFC PATCH 4/8] ARM: entry: don't bother with syscall tracing on ret_from_fork path Will Deacon
2012-06-22 15:07 ` [RFC PATCH 5/8] ARM: audit: move syscall auditing until after ptrace SIGTRAP handling Will Deacon
2012-06-22 15:07 ` [RFC PATCH 6/8] ARM: ptrace: provide separate functions for tracing syscall {entry, exit} Will Deacon
2012-06-22 15:07 ` [RFC PATCH 7/8] ARM: signal: perform restart_block system call restarting in the kernel Will Deacon
2012-06-22 15:07 ` Will Deacon [this message]
2012-06-22 19:36 ` [RFC PATCH 0/8] Fix restart_block syscall restarting for 3.5 Al Viro
2012-06-25  9:18   ` Will Deacon
2012-06-26 14:33     ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340377626-17075-9-git-send-email-will.deacon@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.