From: Joe Perches <joe@perches.com>
To: "devendra.aaru" <devendra.aaru@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Justin P. Mattock" <justinmattock@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/3] staging/rtl8192u: fix coding style problems
Date: Sat, 23 Jun 2012 13:51:55 -0700 [thread overview]
Message-ID: <1340484715.7758.22.camel@joe2Laptop> (raw)
In-Reply-To: <CAHdPZaMH1vJPsFmGFrrpWNtCxuY+S35-w2j+gbiiE=7jVKLtUQ@mail.gmail.com>
On Sun, 2012-06-24 at 00:04 +0530, devendra.aaru wrote:
> Hi Joe,
Hi Devendra.
> On Thu, Jun 21, 2012 at 4:48 AM, Joe Perches <joe@perches.com> wrote:
> > I'd just make the return a bool instead.
> taking another variable and assign it like bool ret = !!bit, and
> returning ret?, i think this doesn't look better.
No. just
return val;
or
return (bool)val;
if using the implicit conversion bothers you.
next prev parent reply other threads:[~2012-06-23 20:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 19:05 [PATCH V2 1/3] staging/rtl8192u: fix coding style problems Devendra Naga
2012-06-20 23:08 ` Greg Kroah-Hartman
2012-06-20 23:18 ` Joe Perches
2012-06-23 18:34 ` devendra.aaru
2012-06-23 19:10 ` Dan Carpenter
2012-06-23 20:51 ` Joe Perches [this message]
2012-06-23 18:29 ` devendra.aaru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340484715.7758.22.camel@joe2Laptop \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=devendra.aaru@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=justinmattock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.