All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Thomas Lange <thomas@corelatus.se>
Cc: mingo@redhat.com, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [BUG] sched: clock wrap bug in 2.6.35-stable kills scheduling
Date: Mon, 25 Jun 2012 12:38:26 +0200	[thread overview]
Message-ID: <1340620706.2507.51.camel@laptop> (raw)
In-Reply-To: <1340617541.2507.50.camel@laptop>

On Mon, 2012-06-25 at 11:45 +0200, Peter Zijlstra wrote:
> On Sun, 2012-06-24 at 19:32 +0200, Thomas Lange wrote:
> > Bug was introduced in 2.6.35.12 and is still present in linux-2.6.35.y HEAD.
> 
> Ok, so nobody cares about that.. what does something recent like 3.5-rc4
> do?
> 
> If that's fixed, find the patch that fixes it. If not, we'll have a
> look.


If anything, I think something like the below ought to cure things.

---
 kernel/sched/clock.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/clock.c b/kernel/sched/clock.c
index c685e31..a1a128a 100644
--- a/kernel/sched/clock.c
+++ b/kernel/sched/clock.c
@@ -74,7 +74,7 @@
  */
 unsigned long long __attribute__((weak)) sched_clock(void)
 {
-	return (unsigned long long)(jiffies - INITIAL_JIFFIES)
+	return (unsigned long long)(get_jiffies_64() - INITIAL_JIFFIES)
 					* (NSEC_PER_SEC / HZ);
 }
 EXPORT_SYMBOL_GPL(sched_clock);



  reply	other threads:[~2012-06-25 10:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-24 17:32 [BUG] sched: clock wrap bug in 2.6.35-stable kills scheduling Thomas Lange
2012-06-24 17:52 ` Greg KH
2012-06-25  9:45 ` Peter Zijlstra
2012-06-25 10:38   ` Peter Zijlstra [this message]
2012-06-25 18:49     ` Thomas Lange
2012-06-25 19:33       ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340620706.2507.51.camel@laptop \
    --to=peterz@infradead.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=thomas@corelatus.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.