From: Stephan Linz <linz@li-pro.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] microblaze: avoid compile error on systems without cfi flash
Date: Tue, 26 Jun 2012 18:56:47 +0200 [thread overview]
Message-ID: <1340729807.2767.51.camel@keto> (raw)
In-Reply-To: <CAHTX3d+hTLHxzghdGVwUKp-WtRdKvi8M+HNrH4tEAaFyz8DRYA@mail.gmail.com>
Am Dienstag, den 26.06.2012, 10:56 +0200 schrieb Michal Simek:
> 2012/6/25 Stephan Linz <linz@li-pro.net>:
> > Am Montag, den 25.06.2012, 06:55 +0200 schrieb Michal Simek:
> >> On 06/21/2012 09:42 PM, Stephan Linz wrote:
> >> > Use XILINX_FLASH_START to set/unset FLASH and RAMENV.
> >> >
> >> > Error was:
> >> > board.c: In function 'board_init':
> >> > board.c:134: error: 'XILINX_FLASH_START' undeclared (first use in this function)
> >> > board.c:134: error: (Each undeclared identifier is reported only once
> >> > board.c:134: error: for each function it appears in.)
> >> >
> >> > Signed-off-by: Stephan Linz<linz@li-pro.net>
> >> > ---
> >> > include/configs/microblaze-generic.h | 14 +++++++++-----
> >> > 1 files changed, 9 insertions(+), 5 deletions(-)
> >> >
> >> > --snip--
> >>
> >> What's wrong with hardware flash protection?
> >
> > Nothing, but it will defined twice. One time in line 182 and one time in
> > that line 204. I think the last one is wrong, because that define is
> > outside the Flash configuration context, or not?
> >
> > Sorry, I should split the patch. Should I do this?
>
> Two ways.
> 1. write it to description
> 2. create separate patch
>
> Option 2 is IMHO better.
Yes I do so. I'll split the patch and resubmit together with the UBI
support patch.
br,
Stephan
prev parent reply other threads:[~2012-06-26 16:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 19:42 [U-Boot] [PATCH 1/2] microblaze: avoid compile error on systems without cfi flash Stephan Linz
2012-06-21 19:42 ` [U-Boot] [PATCH 2/2] microblaze: Enable ubi support Stephan Linz
2012-06-25 5:04 ` Michal Simek
2012-06-25 7:22 ` Wolfgang Denk
2012-06-25 17:08 ` Stephan Linz
2012-06-26 8:52 ` Michal Simek
2012-06-26 16:56 ` Stephan Linz
2012-06-25 4:55 ` [U-Boot] [PATCH 1/2] microblaze: avoid compile error on systems without cfi flash Michal Simek
2012-06-25 17:08 ` Stephan Linz
2012-06-26 8:56 ` Michal Simek
2012-06-26 16:56 ` Stephan Linz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340729807.2767.51.camel@keto \
--to=linz@li-pro.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.