From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Namhyung Kim <namhyung@kernel.org>,
Jovi Zhang <bookjovi@gmail.com>,
mingo@redhat.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf: fix wrong hw_breakpoint documentation
Date: Wed, 27 Jun 2012 21:58:22 +0200 [thread overview]
Message-ID: <1340827102.10063.72.camel@twins> (raw)
In-Reply-To: <20120627190725.GA1380@krava.redhat.com>
On Wed, 2012-06-27 at 21:07 +0200, Jiri Olsa wrote:
> -modifier_bp [rwx]
> +modifier_bp [rwx]{1,3}
>
> and fail parse_breakpoint_type function for nonsense types
If you're going to modify parse_breakpoint_type() to fail on nonsense
types, you might as well do the + thing, right?
Doesn't really matter that much though ;-)
next prev parent reply other threads:[~2012-06-27 19:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 8:39 [PATCH] perf: fix wrong hw_breakpoint documentation Jovi Zhang
2012-06-27 8:59 ` Namhyung Kim
2012-06-27 13:40 ` Jovi Zhang
2012-06-27 16:15 ` Arnaldo Carvalho de Melo
2012-06-27 19:07 ` Jiri Olsa
2012-06-27 19:58 ` Peter Zijlstra [this message]
2012-06-27 20:19 ` Jiri Olsa
2012-06-28 1:30 ` Namhyung Kim
2012-06-28 10:32 ` Jiri Olsa
2012-06-28 21:18 ` [PATCH 0/2] perf, tool: Hw breakpoint events parsing fixes Jiri Olsa
2012-06-28 21:18 ` [PATCH 1/2] perf, tool: Fix hw breakpoint's type modifier parsing Jiri Olsa
2012-06-29 0:40 ` Namhyung Kim
2012-06-29 1:01 ` Jovi Zhang
2012-06-29 1:34 ` Namhyung Kim
2012-06-29 7:22 ` [PATCHv2 " Jiri Olsa
2012-07-06 10:57 ` [tip:perf/core] perf tools: Fix hw breakpoint' s " tip-bot for Jiri Olsa
2012-06-28 21:18 ` [PATCH 2/2] perf, tool: Handle hw breakpoints event names via perf_evsel__name Jiri Olsa
2012-07-06 10:58 ` [tip:perf/core] perf evsel: Handle hw breakpoints event names in perf_evsel__name() tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340827102.10063.72.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=bookjovi@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.