Re: [PATCH] cfg80211/mac80211: 802.11ac changes

[Johannes Berg <johannes@sipsolutions.net>]

Ok I applied some of the changes (see mac80211-next tree), but not the
mac80211 pieces. Please fix:


> +	if (supp_vht)
> +		local->scan_ies_len += 2 + sizeof(struct ieee80211_vht_capabilities);

too long line

>  
> +	if (sband->vht_cap.vht_supported)
> +		pos = ieee80211_ie_build_vht_cap(pos, &sband->vht_cap,
> +						sband->vht_cap.cap);

indentation

>  	return pos - buffer;
>  }
>  
> @@ -1696,6 +1700,27 @@ u8 *ieee80211_ie_build_ht_cap(u8 *pos, struct ieee80211_sta_ht_cap *ht_cap,
>  	return pos;
>  }
>  
> +u8 *ieee80211_ie_build_vht_cap(u8 *pos, struct ieee80211_sta_vht_cap *vht_cap,
> +			      u32 cap)

indentation here & in ieee80211_i.h

> +	__le32 tmp;
> +
> +	*pos++ = WLAN_EID_VHT_CAPABILITY;
> +	*pos++ = sizeof(struct ieee80211_vht_capabilities);
> +	memset(pos, 0, sizeof(struct ieee80211_vht_capabilities));
> +
> +	/* capability flags */
> +	tmp = cpu_to_le16(cap);
> +	memcpy(pos, &tmp, sizeof(u32));
> +	pos += sizeof(u32);
> +
> +	/* VHT MCS set */
> +	memcpy(pos, &vht_cap->vht_mcs, sizeof(vht_cap->vht_mcs));
> +	pos += sizeof(vht_cap->vht_mcs);
> +

endian issues

johannes