From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perches-mx.perches.com ([206.117.179.246]:48104 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750769Ab2F1UFu (ORCPT ); Thu, 28 Jun 2012 16:05:50 -0400 Message-ID: <1340913949.2602.27.camel@joe2Laptop> (sfid-20120628_220626_871535_BF9A4673) Subject: Re: [PATCH option A] bcma: use custom printing functions From: Joe Perches To: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= Cc: Johannes Berg , linux-wireless@vger.kernel.org, Hauke Mehrtens Date: Thu, 28 Jun 2012 13:05:49 -0700 In-Reply-To: References: <1340912688-3089-1-git-send-email-zajec5@gmail.com> <1340912894.5257.0.camel@jlt3.sipsolutions.net> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, 2012-06-28 at 21:56 +0200, Rafał Miłecki wrote: > 2012/6/28 Johannes Berg : > > On Thu, 2012-06-28 at 21:44 +0200, Rafał Miłecki wrote: > > > >> +#define bcma_err(fmt, ...) \ > >> + pr_err(KBUILD_MODNAME "-%d: " fmt, bus->num, ##__VA_ARGS__) > > > > both of your options seem to rely on "bus" being a variable in the > > context, is that really a good idea? > > Yeah, I made that assumption to make calls nicer & shorter. We may > need to get reference to "bus" in function or two. > > I saw such a solution in "radeon" gpu driver, example: > value = RREG32(R600_AUDIO_STATUS_BITS); > (they assume "rdev" is available in every function calling RREG32). I think that radeon use is ugly myself. > If you believe it's ugly, I can change that. I also wonder what Joe > will respond. > > P.S. > Both patches are not signed yet and they are supposed to be RFC. Sorry > for missing that in subject line. I think it'd be better to add and use: #define bcma_bus_err(bus, fmt, ...) \ pr_err("bus %d: " fmt, (bus)->num, ##__VA_ARGS__) #define bcma_bus_info(bus, fmt, ...) \ pr_info("bus %d: " fmt, (bus)->num, ##__VA_ARGS__) or some other equivalent use if you're wedded to wanting "bcma-%d:" prefixed output. I'd rather have the prefix be something like "bcma: : ", so a dmesg grep pattern can be "^bcma:" but hey, it ain't my code. Do what you think best. cheers, Joe