From: Axel Lin <axel.lin@gmail.com>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: linux-kernel@vger.kernel.org, Alexey Charkov <alchark@gmail.com>
Subject: [PATCH v2 3/3] pwm: Convert pwm-vt8500 to use devm_* APIs
Date: Sun, 01 Jul 2012 08:29:28 +0800 [thread overview]
Message-ID: <1341102568.3712.2.camel@phoenix> (raw)
In-Reply-To: <1341102443.3712.0.camel@phoenix>
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/pwm/pwm-vt8500.c | 47 ++++++++--------------------------------------
1 file changed, 8 insertions(+), 39 deletions(-)
diff --git a/drivers/pwm/pwm-vt8500.c b/drivers/pwm/pwm-vt8500.c
index 3db0746..5480214 100644
--- a/drivers/pwm/pwm-vt8500.c
+++ b/drivers/pwm/pwm-vt8500.c
@@ -1,5 +1,5 @@
/*
- * arch/arm/mach-vt8500/pwm.c
+ * drivers/pwm/pwm-vt8500.c
*
* Copyright (C) 2010 Alexey Charkov <alchark@gmail.com>
*
@@ -113,7 +113,7 @@ static int __devinit pwm_probe(struct platform_device *pdev)
struct resource *r;
int ret;
- chip = kzalloc(sizeof(*chip), GFP_KERNEL);
+ chip = devm_kzalloc(&pdev->dev, sizeof(*chip), GFP_KERNEL);
if (chip == NULL) {
dev_err(&pdev->dev, "failed to allocate memory\n");
return -ENOMEM;
@@ -127,61 +127,30 @@ static int __devinit pwm_probe(struct platform_device *pdev)
r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (r == NULL) {
dev_err(&pdev->dev, "no memory resource defined\n");
- ret = -ENODEV;
- goto err_free;
+ return -ENODEV;
}
- r = request_mem_region(r->start, resource_size(r), pdev->name);
- if (r == NULL) {
- dev_err(&pdev->dev, "failed to request memory resource\n");
- ret = -EBUSY;
- goto err_free;
- }
-
- chip->base = ioremap(r->start, resource_size(r));
- if (chip->base == NULL) {
- dev_err(&pdev->dev, "failed to ioremap() registers\n");
- ret = -ENODEV;
- goto err_free_mem;
- }
+ chip->base = devm_request_and_ioremap(&pdev->dev, r);
+ if (chip->base == NULL)
+ return -EADDRNOTAVAIL;
ret = pwmchip_add(&chip->chip);
if (ret < 0)
- goto err_unmap;
+ return ret;
platform_set_drvdata(pdev, chip);
return ret;
-
-err_unmap:
- iounmap(chip->base);
-err_free_mem:
- release_mem_region(r->start, resource_size(r));
-err_free:
- kfree(chip);
- return ret;
}
static int __devexit pwm_remove(struct platform_device *pdev)
{
struct vt8500_chip *chip;
- struct resource *r;
- int err;
chip = platform_get_drvdata(pdev);
if (chip == NULL)
return -ENODEV;
- err = pwmchip_remove(&chip->chip);
- if (err < 0)
- return err;
-
- iounmap(chip->base);
-
- r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- release_mem_region(r->start, resource_size(r));
-
- kfree(chip);
- return 0;
+ return pwmchip_remove(&chip->chip);
}
static struct platform_driver pwm_driver = {
--
1.7.9.5
next prev parent reply other threads:[~2012-07-01 0:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-01 0:27 [PATCH v2 1/3] pwm: Convert pwm-imx to use devm_* APIs Axel Lin
2012-07-01 0:28 ` [PATCH v2 2/3] pwm: Convert pwm-pxa " Axel Lin
2012-07-01 7:36 ` Thierry Reding
2012-07-01 9:53 ` Axel Lin
2012-07-01 0:29 ` Axel Lin [this message]
2012-07-02 20:48 ` [PATCH v2 3/3] pwm: Convert pwm-vt8500 " Thierry Reding
2012-07-02 20:49 ` [PATCH v2 1/3] pwm: Convert pwm-imx " Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341102568.3712.2.camel@phoenix \
--to=axel.lin@gmail.com \
--cc=alchark@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.