From: Lin Ming <ming.m.lin@intel.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Jeff Garzik <jeff@garzik.org>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Matthew Garrett <mjg@redhat.com>, Holger Macht <holger@homac.de>
Subject: Re: linux-next: build warnings after merge of the libata tree
Date: Mon, 02 Jul 2012 12:31:19 +0800 [thread overview]
Message-ID: <1341203479.31272.4.camel@minggr> (raw)
In-Reply-To: <20120702135429.0d17c1f4fe46828bd29b3458@canb.auug.org.au>
On Mon, 2012-07-02 at 13:54 +1000, Stephen Rothwell wrote:
> Hi Lin,
>
> On Mon, 02 Jul 2012 11:21:58 +0800 Lin Ming <ming.m.lin@intel.com> wrote:
> >
> > Could you please send me your ppc64 .config?
> > I'll do cross build on my x86 machine.
>
> Please just look at the code added in drivers/ata/libata.h. Hint: what
> happens if CONFIG_ATA_ACPI is *not* defined?
>
Hi Stephen,
Could you pick below fix?
Thanks.
>From cc270d0b3b132a37290db5fe3941361243540a18 Mon Sep 17 00:00:00 2001
From: Lin Ming <ming.m.lin@intel.com>
Date: Mon, 2 Jul 2012 12:20:39 +0800
Subject: [PATCH] libata-acpi: add missing inlines in libata.h
Adds inline for ata_acpi_unregister/ata_acpi_bind/ata_acpi_unbind
in drivers/ata/libata.h for !CONFIG_ATA_ACPI to fix below warnings.
warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
warning: 'ata_acpi_bind' defined but not used [-Wunused-function]
warning: 'ata_acpi_unbind' defined but not used [-Wunused-function]
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Lin Ming <ming.m.lin@intel.com>
---
drivers/ata/libata.h | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ata/libata.h b/drivers/ata/libata.h
index 44a7939..50e4dff 100644
--- a/drivers/ata/libata.h
+++ b/drivers/ata/libata.h
@@ -131,9 +131,9 @@ static inline void ata_acpi_on_disable(struct ata_device *dev) { }
static inline void ata_acpi_set_state(struct ata_port *ap,
pm_message_t state) { }
static inline int ata_acpi_register(void) { return 0; }
-static void ata_acpi_unregister(void) { }
-static void ata_acpi_bind(struct ata_device *dev) { }
-static void ata_acpi_unbind(struct ata_device *dev) { }
+static inline void ata_acpi_unregister(void) { }
+static inline void ata_acpi_bind(struct ata_device *dev) { }
+static inline void ata_acpi_unbind(struct ata_device *dev) { }
#endif
/* libata-scsi.c */
--
1.7.2.5
next prev parent reply other threads:[~2012-07-02 4:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 3:19 linux-next: build warnings after merge of the libata tree Stephen Rothwell
2012-07-02 3:21 ` Lin Ming
2012-07-02 3:54 ` Stephen Rothwell
2012-07-02 4:31 ` Lin Ming [this message]
2012-07-02 6:11 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2016-07-21 5:26 Stephen Rothwell
2016-07-21 14:44 ` Tejun Heo
2016-07-27 6:32 ` Stephen Rothwell
2016-07-27 17:33 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341203479.31272.4.camel@minggr \
--to=ming.m.lin@intel.com \
--cc=holger@homac.de \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.