From: Roland Dreier <roland@kernel.org>
To: Tomas Winkler <tomas.winkler@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lekensteyn <lekensteyn@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] misc: mei: set IRQF_ONESHOT for MSI request_threaded_irq() in mei_pci_resume()
Date: Tue, 3 Jul 2012 02:08:30 -0700 [thread overview]
Message-ID: <1341306510-28808-1-git-send-email-roland@kernel.org> (raw)
In-Reply-To: <15236906.ttExm1X813@al>
From: Roland Dreier <roland@purestorage.com>
When the default quick IRQ handler is used then IRQF_ONESHOT must be set,
or else the request fails and following error is logged on resume:
genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq ...
This is the same fix that commit aa189ecdc0c7 ("misc: mei: set
IRQF_ONESHOT for msi request_threaded_irq") did in the probe function.
Reported-by: Lekensteyn <lekensteyn@gmail.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
---
Can you try this? It looks to be needed.
Thomas/Greg, I think this should get into 3.5 if possible.
drivers/misc/mei/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c
index 7de1389..783fcd7 100644
--- a/drivers/misc/mei/main.c
+++ b/drivers/misc/mei/main.c
@@ -1147,7 +1147,7 @@ static int mei_pci_resume(struct device *device)
err = request_threaded_irq(pdev->irq,
NULL,
mei_interrupt_thread_handler,
- 0, mei_driver_name, dev);
+ IRQF_ONESHOT, mei_driver_name, dev);
else
err = request_threaded_irq(pdev->irq,
mei_interrupt_quick_handler,
--
1.7.10.4
next prev parent reply other threads:[~2012-07-03 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 22:22 MEI: suspend/IRQ warnings Lekensteyn
2012-07-03 9:08 ` Roland Dreier [this message]
2012-07-03 12:12 ` [PATCH] misc: mei: set IRQF_ONESHOT for MSI request_threaded_irq() in mei_pci_resume() Winkler, Tomas
2012-07-03 16:49 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341306510-28808-1-git-send-email-roland@kernel.org \
--to=roland@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lekensteyn@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.