All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: netdev <netdev@vger.kernel.org>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: [PATCH] etherdevice: introduce broadcast_ether_addr
Date: Tue, 03 Jul 2012 12:16:27 +0200	[thread overview]
Message-ID: <1341310587.5131.2.camel@jlt3.sipsolutions.net> (raw)

From: Johannes Berg <johannes.berg@intel.com>

A lot of code has either the memset or an
inefficient copy from a static array that
contains the all-ones broadcast address.
Introduce broadcast_ether_addr() to fill
an address with all ones, making the code
clearer and allowing us to get rid of the
various constant arrays.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 include/linux/etherdevice.h |   11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h
index 3d406e0..6da05bb 100644
--- a/include/linux/etherdevice.h
+++ b/include/linux/etherdevice.h
@@ -138,6 +138,17 @@ static inline void random_ether_addr(u8 *addr)
 }
 
 /**
+ * broadcast_ether_addr - Assign broadcast address
+ * @addr: Pointer to a six-byte array containing the Ethernet address
+ *
+ * Assign the broadcast address to the given address array.
+ */
+static inline void broadcast_ether_addr(u8 *addr)
+{
+	memset(addr, 0xff, ETH_ALEN);
+}
+
+/**
  * eth_hw_addr_random - Generate software assigned random Ethernet and
  * set device flag
  * @dev: pointer to net_device structure
-- 
1.7.10




             reply	other threads:[~2012-07-03 10:16 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-03 10:16 Johannes Berg [this message]
2012-07-03 15:13 ` [PATCH] etherdevice: introduce broadcast_ether_addr Joe Perches
2012-07-03 15:16   ` Johannes Berg
2012-07-09  6:58 ` David Miller
2012-07-09  6:58   ` David Miller
2012-07-10 16:18   ` [PATCH] etherdevice: introduce eth_broadcast_addr Johannes Berg
2012-07-11  0:09     ` Paul Gortmaker
2012-07-11  0:41       ` David Miller
2012-07-11  1:09         ` Joe Perches
2012-07-11  1:09           ` Joe Perches
2012-07-13  5:33           ` [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr Joe Perches
2012-07-13  5:33             ` [PATCH net-next 1/8] " Joe Perches
2012-07-13  5:33             ` [PATCH net-next 2/8] ethernet: Use eth_random_addr Joe Perches
2012-07-13  5:33               ` Joe Perches
2012-07-13  5:33             ` [PATCH net-next 3/8] net: usb: " Joe Perches
2012-07-13  5:33             ` [PATCH net-next 4/8] wireless: " Joe Perches
2012-07-13  5:54               ` Hin-Tak Leung
2012-07-13  7:15               ` Gertjan van Wingerde
2012-07-13  7:15                 ` Gertjan van Wingerde
2012-07-13  5:33             ` [PATCH net-next 5/8] drivers/net: " Joe Perches
2012-07-13  5:33             ` [PATCH net-next 6/8] s390: " Joe Perches
2012-07-13  5:33             ` [PATCH net-next 7/8] usb: " Joe Perches
2012-07-16 11:15               ` Felipe Balbi
2012-07-13  5:33             ` [PATCH net-next 8/8] arch: " Joe Perches
2012-07-15 21:51               ` Mike Frysinger
2012-07-16 12:56               ` Mark Salter
2012-07-16 14:20               ` Ralf Baechle
2012-07-16 10:14             ` [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr Felipe Balbi
2012-07-16 10:14               ` Felipe Balbi
2012-07-16 10:29               ` David Miller
2012-07-16 10:29                 ` David Miller
2012-07-16 11:12                 ` Felipe Balbi
2012-07-16 11:17                   ` David Miller
2012-07-16 11:17                     ` David Miller
2012-07-17  5:39             ` David Miller
2012-07-17  5:39               ` David Miller
2012-07-11  7:27       ` [PATCH] etherdevice: introduce eth_broadcast_addr Johannes Berg
2012-07-11  7:27         ` Johannes Berg
2012-07-11  1:07     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341310587.5131.2.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.