All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: [PATCH] compat-wireless: fix debugging in iwlwifi
Date: Tue, 03 Jul 2012 15:28:28 +0200	[thread overview]
Message-ID: <1341322108.20124.3.camel@jlt3.sipsolutions.net> (raw)

From: Johannes Berg <johannes.berg@intel.com>

As compat includes linux/device.h well before iwlwifi, the
definitions from there are used without DEBUG, but iwlwifi
defines DEBUG to get debug output. Use dev_printk instead
of dev_dbg to get debugging back.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 patches/57-iwlwifi-debug-fix.patch |   19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 patches/57-iwlwifi-debug-fix.patch

diff --git a/patches/57-iwlwifi-debug-fix.patch b/patches/57-iwlwifi-debug-fix.patch
new file mode 100644
index 0000000..4b2dfa9
--- /dev/null
+++ b/patches/57-iwlwifi-debug-fix.patch
@@ -0,0 +1,19 @@
+Due to compat including linux/device.h before we do,
+we don't get a chance to #define DEBUG to get our
+debugging prints. This patch replaces dev_dbg with
+dev_printk to make them show up again.
+
+--- a/drivers/net/wireless/iwlwifi/iwl-debug.c
++++ b/drivers/net/wireless/iwlwifi/iwl-debug.c
+@@ -138,8 +138,9 @@ void __iwl_dbg(struct device *dev,
+ 
+ 		va_copy(args2, args);
+ 		vaf.va = &args2;
+-		dev_dbg(dev, "%c %s %pV", in_interrupt() ? 'I' : 'U',
+-			function, &vaf);
++		dev_printk(KERN_DEBUG, dev, "%c %s %pV",
++			   in_interrupt() ? 'I' : 'U',
++			   function, &vaf);
+ 		va_end(args2);
+ 	}
+ #endif
-- 
1.7.10




             reply	other threads:[~2012-07-03 13:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-03 13:28 Johannes Berg [this message]
2012-07-03 15:47 ` [PATCH] compat-wireless: fix debugging in iwlwifi Luis R. Rodriguez
2012-07-03 16:16   ` Luis R. Rodriguez
2012-07-03 16:21     ` Johannes Berg
2012-07-03 16:28       ` Joe Perches
2012-07-03 16:47         ` Johannes Berg
2012-07-09 22:27           ` Luis R. Rodriguez
2012-07-03 16:30       ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341322108.20124.3.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mcgrof@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.