Re: [PATCH] fetch2: try PREMIRRORS when calculating latest_revision

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Sun, 2012-07-01 at 11:52 +0200, Enrico Scholz wrote:
> Since support for native git mirrors was added in recent bitbake, it
> is possible to use local mirrors for calculating ${AUTOREV}.  This is
> very useful for development: recipes SRCREV can be overridden locally
> by 'SRCREV_pn-<recipe> = ${AUTOREV}' and a PREMIRROR which refers to a
> local repository can be added for the SRC_URI .
> 
> Patch checks PREMIRRORS only but not normal MIRRORS because:
> 
> a) it can break things when upstream is temporarily unavailable while
>    calling latest_revision() (--> MIRRORS will be consulted) but comes
>    back when fetching source.
> 
> b) it makes the error reporting more complicated (only errors for
>    upstream should be shown to user, not the MIRROR's ones).
> 
> Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
> ---
>  lib/bb/fetch2/__init__.py |   25 ++++++++++++++++++++++++-
>  1 file changed, 24 insertions(+), 1 deletion(-)

I'm torn over this one. If you want to refer to local changes wouldn't
it make more sense just to totally override SRC_URI in cases like this,
then things are specific.

I'm worried that here, upstream revisions may just get ignored for
example with just a premirror copy being consulted and this wouldn't be
the expected behaviour a user would want.

Cheers,

Richard