All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amos Kong <akong@redhat.com>
To: aliguori@us.ibm.com, eblake@redhat.com, berrange@redhat.com,
	lcapitulino@redhat.com, qemu-devel@nongnu.org
Cc: Amos Kong <akong@redhat.com>
Subject: [Qemu-devel] [PATCH v4 3/6] hmp: rename arguments
Date: Thu,  5 Jul 2012 20:48:42 +0800	[thread overview]
Message-ID: <1341492525-29809-4-git-send-email-akong@redhat.com> (raw)
In-Reply-To: <1341492525-29809-1-git-send-email-akong@redhat.com>

Rename 'string' to 'keys', rename 'hold_time' to 'hold-time'.

Signed-off-by: Amos Kong <akong@redhat.com>
---
 hmp-commands.hx |    2 +-
 monitor.c       |   14 +++++++-------
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/hmp-commands.hx b/hmp-commands.hx
index 30243b6..e336251 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -502,7 +502,7 @@ ETEXI
 
     {
         .name       = "sendkey",
-        .args_type  = "string:s,hold_time:i?",
+        .args_type  = "keys:s,hold-time:i?",
         .params     = "keys [hold_ms]",
         .help       = "send keys to the VM (e.g. 'sendkey ctrl-alt-f1', default hold time=100 ms)",
         .mhandler.cmd = do_sendkey,
diff --git a/monitor.c b/monitor.c
index e87677d..6fa0104 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1511,9 +1511,9 @@ static void do_sendkey(Monitor *mon, const QDict *qdict)
     char keyname_buf[16];
     char *separator;
     int keyname_len, keycode, i;
-    const char *string = qdict_get_str(qdict, "string");
-    int has_hold_time = qdict_haskey(qdict, "hold_time");
-    int hold_time = qdict_get_try_int(qdict, "hold_time", -1);
+    const char *keys = qdict_get_str(qdict, "keys");
+    int has_hold_time = qdict_haskey(qdict, "hold-time");
+    int hold_time = qdict_get_try_int(qdict, "hold-time", -1);
 
     if (nb_pending_keycodes > 0) {
         qemu_del_timer(key_timer);
@@ -1523,10 +1523,10 @@ static void do_sendkey(Monitor *mon, const QDict *qdict)
         hold_time = 100;
     i = 0;
     while (1) {
-        separator = strchr(string, '-');
-        keyname_len = separator ? separator - string : strlen(string);
+        separator = strchr(keys, '-');
+        keyname_len = separator ? separator - keys : strlen(keys);
         if (keyname_len > 0) {
-            pstrcpy(keyname_buf, sizeof(keyname_buf), string);
+            pstrcpy(keyname_buf, sizeof(keyname_buf), keys);
             if (keyname_len > sizeof(keyname_buf) - 1) {
                 monitor_printf(mon, "invalid key: '%s...'\n", keyname_buf);
                 return;
@@ -1552,7 +1552,7 @@ static void do_sendkey(Monitor *mon, const QDict *qdict)
         }
         if (!separator)
             break;
-        string = separator + 1;
+        keys = separator + 1;
     }
     nb_pending_keycodes = i;
     /* key down events */
-- 
1.7.1

  parent reply	other threads:[~2012-07-05 12:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-05 12:48 [Qemu-devel] [PATCH v4 0/6] convert sendkey to qapi Amos Kong
2012-07-05 12:48 ` [Qemu-devel] [PATCH v4 1/6] fix doc of using raw values with sendkey Amos Kong
2012-07-05 12:48 ` [Qemu-devel] [PATCH v4 2/6] monitor: rename keyname '<' to 'less' Amos Kong
2012-07-05 12:48 ` Amos Kong [this message]
2012-07-05 12:48 ` [Qemu-devel] [PATCH v4 4/6] qapi: generate list struct and visit_list for enum Amos Kong
2012-07-05 13:01   ` Eric Blake
2012-07-05 12:48 ` [Qemu-devel] [PATCH v4 5/6] qapi: convert sendkey Amos Kong
2012-07-12 15:09   ` Luiz Capitulino
2012-07-18 12:56     ` Amos Kong
2012-07-18 13:50       ` Luiz Capitulino
2012-07-18 18:25         ` Amos Kong
2012-07-25  5:55     ` Amos Kong
2012-07-25 12:38       ` Luiz Capitulino
2012-07-25 13:56         ` Amos Kong
2012-07-05 12:48 ` [Qemu-devel] [PATCH v4 6/6] ps2: output warning when event queue full Amos Kong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341492525-29809-4-git-send-email-akong@redhat.com \
    --to=akong@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.