From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH] drm/i915: Detect the error case for too
	large CRTC offsets
Date: Thu, 05 Jul 2012 18:27:36 +0100
Message-ID: <1341509321_181012@CP5-2952>
References: <1341479410-3073-1-git-send-email-chris@chris-wilson.co.uk>
	<20120705172237.GA97358@dspnet.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236])
	by gabe.freedesktop.org (Postfix) with ESMTP id 7AD38A0F6C
	for <intel-gfx@lists.freedesktop.org>;
	Thu,  5 Jul 2012 10:28:46 -0700 (PDT)
In-Reply-To: <20120705172237.GA97358@dspnet.fr>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Olivier Galibert <galibert@pobox.com>
Cc: intel-gfx@lists.freedesktop.org, stable@kernel.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, 5 Jul 2012 19:22:37 +0200, Olivier Galibert <galibert@pobox.com> wrote:
> On Thu, Jul 05, 2012 at 10:10:10AM +0100, Chris Wilson wrote:
> > +	if (INTEL_INFO(dev)->gen >= 4 && (x|y) & ~4095) {
> > +		DRM_ERROR("CRTC offset too larget (%d, %d)\n", x, y);
> 
> larget?

Not even a humorous typo. Daniel has posted a couple of patches to
actually workaround the limits which obsoletes the need for rejecting
the mode_set_base().
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre