From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn1eP-0003KM-Rc for qemu-devel@nongnu.org; Fri, 06 Jul 2012 02:04:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sn1eO-0007Jc-4U for qemu-devel@nongnu.org; Fri, 06 Jul 2012 02:04:21 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:49667) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn1eN-0007JN-Mn for qemu-devel@nongnu.org; Fri, 06 Jul 2012 02:04:20 -0400 Received: by pbbro12 with SMTP id ro12so15266462pbb.4 for ; Thu, 05 Jul 2012 23:04:17 -0700 (PDT) From: Dunrong Huang Date: Fri, 6 Jul 2012 14:04:43 +0800 Message-Id: <1341554683-20116-1-git-send-email-riegamaths@gmail.com> Subject: [Qemu-devel] [PATCH v2] slirp: Ensure smbd and shared directory exist when enable smb List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Mark McLoughlin , Anthony Liguori , Jan Kiszka Users may pass the following parameters to qemu: $ qemu-kvm -net nic -net user,smb= ... $ qemu-kvm -net nic -net user,smb ... $ qemu-kvm -net nic -net user,smb=bad_directory ... In these cases, qemu started successfully while samba server failed to start. Users will confuse since samba server failed silently without any indication of what it did wrong. To avoid it, we check whether the shared directory exist and if users have permission to access this directory when QEMU's "built-in" SMB server is enabled. Signed-off-by: Dunrong Huang --- net/slirp.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index 37b6ccf..ff36fa2 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -489,6 +489,18 @@ static int slirp_smb(SlirpState* s, const char *exported_dir, char smb_cmdline[128]; FILE *f; + if (access(CONFIG_SMBD_COMMAND, F_OK)) { + error_report("could not find '%s', please install it", + CONFIG_SMBD_COMMAND); + return -1; + } + + if (access(exported_dir, R_OK | X_OK)) { + error_report("no such directory '%s', or you do not have permission " + "to access it, please check it", exported_dir); + return -1; + } + snprintf(s->smb_dir, sizeof(s->smb_dir), "/tmp/qemu-smb.%ld-%d", (long)getpid(), instance++); if (mkdir(s->smb_dir, 0700) < 0) { -- 1.7.8.4