From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: tcf-agent, matchbox-wm-2: Correct "proto=git" to "protocol=git".
Date: Mon, 09 Jul 2012 18:00:47 +0100 [thread overview]
Message-ID: <1341853247.8066.36.camel@ted> (raw)
In-Reply-To: <CAK18fxGjWFXQ4C40QgmCnk5G3PucaN4JzDAsDhMb4m6+pxNxzg@mail.gmail.com>
On Mon, 2012-07-09 at 12:27 +0300, Andrei Gherzan wrote:
> On Sat, Jul 7, 2012 at 1:54 PM, Robert P. J. Day
> <rpjday@crashcourse.ca> wrote:
>
> "proto=git" is not a valid parameter for the git fetcher.
>
> NOTE: package matchbox-wm-2-0.1+git1
> +01fa5465743c9ee43d040350f4405d35293e4869-r1: task do_fetch:
> Succeeded
>
> Anyway, in the git.py, code is searching for "protocol" parameter:
> ud.proto = ud.parm['protocol']
>
> ... so your change seems legit.
>
> On another hand, svn.py is using:
> proto = ud.parm.get('proto', 'svn')
>
> A good think would be to use the same parameter names for all
> protocols.
>
I agree but how do we do this without breaking the world? We probably
should try and standardise it, probably to "protocol".
Cheers,
Richard
next prev parent reply other threads:[~2012-07-09 17:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-07 10:54 tcf-agent, matchbox-wm-2: Correct "proto=git" to "protocol=git" Robert P. J. Day
2012-07-09 9:27 ` Andrei Gherzan
2012-07-09 17:00 ` Richard Purdie [this message]
2012-07-09 17:40 ` Khem Raj
2012-07-09 20:22 ` Andrei Gherzan
2012-07-09 21:08 ` Robert P. J. Day
2012-07-09 22:12 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341853247.8066.36.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.