From: Devendra Naga <devendra.aaru@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lior Dotan <liodot@gmail.com>,
Christopher Harrer <charrer@alacritech.com>,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Cc: Devendra Naga <devendra.aaru@gmail.com>
Subject: [PATCH 3/3] staging/slicoss: return -ENODEV if no devid matches
Date: Mon, 9 Jul 2012 23:04:20 +0530 [thread overview]
Message-ID: <1341855260-9037-3-git-send-email-devendra.aaru@gmail.com> (raw)
In-Reply-To: <1341855260-9037-1-git-send-email-devendra.aaru@gmail.com>
if no case matches we are simply asserting and doing break.
and i think we may need to return that -ENODEV , no device is
present, rather assert'ing.
Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
---
drivers/staging/slicoss/slicoss.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
index 5bd3825..56829fc 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -3746,8 +3746,7 @@ static u32 slic_card_locate(struct adapter *adapter)
rdhostid_offset = SLIC_RDHOSTID_1GB;
break;
default:
- ASSERT(0);
- break;
+ return -ENODEV;
}
hostid_reg =
--
1.7.9.5
prev parent reply other threads:[~2012-07-09 17:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 17:34 [PATCH 1/3] staging/slicoss: remove not-needed ASSERT Devendra Naga
2012-07-09 17:34 ` [PATCH 2/3] staging/slicoss: disable pci device at remove Devendra Naga
2012-07-09 20:06 ` Greg Kroah-Hartman
2012-07-09 20:09 ` Eric W. Biederman
2012-07-10 18:28 ` Greg Kroah-Hartman
2012-07-11 5:03 ` devendra.aaru
2012-07-09 17:34 ` Devendra Naga [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341855260-9037-3-git-send-email-devendra.aaru@gmail.com \
--to=devendra.aaru@gmail.com \
--cc=charrer@alacritech.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liodot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.