Re: [PATCH 0/5] Modify fetchers to warn user if "param" is used

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Tue, 2012-07-10 at 18:04 +0300, Andrei Gherzan wrote:
> On Tue, Jul 10, 2012 at 4:33 PM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
>         On Tue, 2012-07-10 at 14:15 +0300, Andrei Gherzan wrote:
>         > Andrei Gherzan (5):
>         >   fetch2/bzr.py: Use "protocol" parameter and warn user if
>         recipe is
>         >     using "proto"
>         >   fetch2/git.py: Use "protocol" parameter and warn user if
>         recipe is
>         >     using "proto"
>         >   fetch2/hg.py: Use "protocol" parameter and warn user if
>         recipe is
>         >     using "proto"
>         >   fetch2/osc.py: Use "protocol" parameter and warn user if
>         recipe is
>         >     using "proto"
>         >   fetch2/svn.py: Use "protocol" parameter and warn user if
>         recipe is
>         >     using "proto"
>         >
>         >  bitbake/lib/bb/fetch2/bzr.py |    7 ++++++-
>         >  bitbake/lib/bb/fetch2/git.py |    4 ++++
>         >  bitbake/lib/bb/fetch2/hg.py  |    7 ++++++-
>         >  bitbake/lib/bb/fetch2/osc.py |    7 ++++++-
>         >  bitbake/lib/bb/fetch2/svn.py |    7 ++++++-
>         >  5 files changed, 28 insertions(+), 4 deletions(-)
>         
>         How about putting this check into __init__.py and then just
>         setting the
>         protocol parameter instead if its used? We can then change the
>         backends
>         just to use procotol right now.
>         
>  
> I can add the warning in init but how would i define the local proto
> value to the one defined with parameter "proto"? 

In FetchData::__init__(), add 

        proto = self.parm.get("proto", None)
        if proto and "protocol" not in self.param:
            self.parm["protocol"] = proto

before urldata_init?

Cheers,

Richard