All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: acme@ghostprotocols.net, mingo@kernel.org, linux-kernel@vger.kernel.org
Cc: David Ahern <dsahern@gmail.com>
Subject: [PATCH 3/4] perf kvm: limit repetitive guestmount message to once
Date: Tue, 10 Jul 2012 15:48:13 -0600	[thread overview]
Message-ID: <1341956894-69284-4-git-send-email-dsahern@gmail.com> (raw)
In-Reply-To: <1341956894-69284-1-git-send-email-dsahern@gmail.com>

After 7ed97ad use of the guestmount option without a subdir for each
VM generates an error message for *each* sample related to that VM. Once
is enough.

Signed-off-by: David Ahern <dsahern@gmail.com>
---
 tools/perf/util/map.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c
index 8668569..641377e 100644
--- a/tools/perf/util/map.c
+++ b/tools/perf/util/map.c
@@ -8,6 +8,7 @@
 #include <unistd.h>
 #include "map.h"
 #include "thread.h"
+#include "asm/bug.h"
 
 const char *map_type__name[MAP__NR_TYPES] = {
 	[MAP__FUNCTION] = "Functions",
@@ -695,7 +696,7 @@ struct machine *machines__findnew(struct rb_root *self, pid_t pid)
 	    (symbol_conf.guestmount)) {
 		sprintf(path, "%s/%d", symbol_conf.guestmount, pid);
 		if (access(path, R_OK)) {
-			pr_err("Can't access file %s\n", path);
+			WARN_ONCE(1, "Can't access file %s\n", path);
 			machine = NULL;
 			goto out;
 		}
-- 
1.7.10.1


  parent reply	other threads:[~2012-07-10 21:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-10 21:48 [PATCH 0/4] perf kvm: more bug fixes and cleanups David Ahern
2012-07-10 21:48 ` [PATCH 1/4] perf kvm: set name for VM process in guest machine David Ahern
2012-07-10 21:48 ` [PATCH 2/4] perf kvm: guest userspace samples should not be lumped with host uspace David Ahern
2012-07-10 21:48 ` David Ahern [this message]
2012-07-10 21:48 ` [PATCH 4/4] perf kvm: fix bug resolving guest kernel syms David Ahern
2012-07-11  0:54   ` Namhyung Kim
2012-07-11  2:16     ` David Ahern
2012-07-11  2:30       ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341956894-69284-4-git-send-email-dsahern@gmail.com \
    --to=dsahern@gmail.com \
    --cc=acme@ghostprotocols.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.