From: Artem Bityutskiy <dedekind1@gmail.com>
To: Ted Ts'o <tytso@mit.edu>
Cc: Ext4 Mailing List <linux-ext4@vger.kernel.org>
Subject: Some warnings
Date: Wed, 11 Jul 2012 12:56:11 +0300 [thread overview]
Message-ID: <1342000571.2963.145.camel@sauron> (raw)
[-- Attachment #1: Type: text/plain, Size: 1555 bytes --]
Hi Ted,
just out of curiosity I've checked the patches you have in the 'dev'
branch with aiaiai - it did not fine anything very bad (but sometimes it
does!), but detected that few warnings.
--------------------------------------------------------------------------------
Successfully built configuration "x86_64_defconfig,x86_64,", results:
--- before_patching.log
+++ after_patching.log
@@ @@
+fs/ext4/ext4.h:1670:47: error: bad constant expression [sparse]
+fs/ext4/ext4.h:1670:47: error: bad constant expression [sparse]
@@ @@
+fs/ext4/resize.c: In function ‘ext4_update_super’:
+fs/ext4/resize.c:1200:9: warning: unused variable ‘ret’ [-Wunused-variable]
@@ @@
+fs/ext4/super.c: In function ‘ext4_statfs’:
+fs/ext4/super.c:4779:15: warning: variable ‘overhead’ set but not used [-Wunused-but-set-variable]
--------------------------------------------------------------------------------
The first one is sparse complaining about using dynamic array as a local
variable which has a potential to blow the stack, generally speaking.
The other ones are just gcc warnings.
In short, aiaia is a script which builds the kernel before patching (and
uses sparse/smatch/coccinelle/cppplus while building) and after patching
and compares to build logs in a smart way, and then tells you about new
warnings/complaints from gcc/sparse/smatch/coccinelle. It also checks
bisectability and reports about failures. I find it very useful for
verifying incoming patches.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next reply other threads:[~2012-07-11 9:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 9:56 Artem Bityutskiy [this message]
2012-07-11 9:58 ` Some warnings Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342000571.2963.145.camel@sauron \
--to=dedekind1@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.