From: Devendra Naga <devendra.aaru@gmail.com>
To: Mark Einon <mark.einon@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Francois Romieu <romieu@fr.zoreil.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Cc: Devendra Naga <devendra.aaru@gmail.com>
Subject: [PATCH 2/2] staging/et131x: remove memset for the TCB
Date: Thu, 12 Jul 2012 11:54:28 +0545 [thread overview]
Message-ID: <1342073368-11893-1-git-send-email-devendra.aaru@gmail.com> (raw)
TCB has kcalloc' ed so no need to call memset again on it.
Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
---
drivers/staging/et131x/et131x.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 227fca9..5010894 100644
--- a/drivers/staging/et131x/et131x.c
+++ b/drivers/staging/et131x/et131x.c
@@ -2131,8 +2131,6 @@ static void et131x_init_send(struct et131x_adapter *adapter)
tx_ring->tcb_qhead = tcb;
- memset(tcb, 0, sizeof(struct tcb) * NUM_TCB);
-
/* Go through and set up each TCB */
for (ct = 0; ct++ < NUM_TCB; tcb++)
/* Set the link pointer in HW TCB to the next TCB in the
--
1.7.9.5
next reply other threads:[~2012-07-12 6:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 6:09 Devendra Naga [this message]
2012-07-12 8:36 ` [PATCH 2/2] staging/et131x: remove memset for the TCB Dan Carpenter
2012-07-12 9:11 ` devendra.aaru
2012-07-12 8:49 ` Alan Cox
2012-07-12 9:07 ` devendra.aaru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342073368-11893-1-git-send-email-devendra.aaru@gmail.com \
--to=devendra.aaru@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.einon@gmail.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.