* [PATCH] staging/sm7xxfb: select sm7xxfb only when CONFIG_PCI is enabled
@ 2012-07-12 8:58 Devendra Naga
0 siblings, 0 replies; only message in thread
From: Devendra Naga @ 2012-07-12 8:58 UTC (permalink / raw)
To: Greg Kroah-Hartman, Javier M. Mellid, devel, linux-kernel,
Fengguang Wu, Dan Carpenter
Cc: Devendra Naga
the sm7xxfb is a pci device, and should depend on the PCI.
And also if we wont' depend on the PCI sub-system, the following warns
will be triggered,
drivers/staging/sm7xxfb/sm7xxfb.c:1061:1: warning: data definition has no type or storage class [enabled by default]
drivers/staging/sm7xxfb/sm7xxfb.c:1061:1: warning: type defaults to 'int' in declaration of 'module_pci_driver' [-Wimplicit-int]
drivers/staging/sm7xxfb/sm7xxfb.c:1061:1: warning: parameter names (without types) in function declaration [enabled by default]
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
---
Hello Fengguang Wu,
I think this solves the build warnings told by you,
sorry for my bad english :(.
drivers/staging/sm7xxfb/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm7xxfb/Kconfig b/drivers/staging/sm7xxfb/Kconfig
index d5013f8..e2922ae 100644
--- a/drivers/staging/sm7xxfb/Kconfig
+++ b/drivers/staging/sm7xxfb/Kconfig
@@ -1,6 +1,6 @@
config FB_SM7XX
tristate "Silicon Motion SM7XX framebuffer support"
- depends on FB
+ depends on FB && PCI
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
--
1.7.9.5
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-07-12 8:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-12 8:58 [PATCH] staging/sm7xxfb: select sm7xxfb only when CONFIG_PCI is enabled Devendra Naga
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.