From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Cc: b29882@freescale.com
Subject: Re: [PATCH] kernel.bbclass: update image name to keep it same in D and DEPLOYDIR
Date: Thu, 12 Jul 2012 12:02:58 +0100 [thread overview]
Message-ID: <1342090978.22262.7.camel@ted> (raw)
In-Reply-To: <1342084646-23822-1-git-send-email-b28495@freescale.com>
On Thu, 2012-07-12 at 04:17 -0500, b28495@freescale.com wrote:
> From: Ting Liu <b28495@freescale.com>
>
> Signed-off-by: Ting Liu <b28495@freescale.com>
> ---
> meta/classes/kernel.bbclass | 7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 81c334b..420a1ec 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -122,7 +122,12 @@ kernel_do_install() {
> #
> install -d ${D}/${KERNEL_IMAGEDEST}
> install -d ${D}/boot
> - install -m 0644 ${KERNEL_OUTPUT} ${D}/${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE}-${KERNEL_VERSION}
> + install -m 0644 ${KERNEL_OUTPUT} ${D}/${KERNEL_IMAGEDEST}/${KERNEL_IMAGE_BASE_NAME}.bin
> + cd ${D}/${KERNEL_IMAGEDEST}/
> + rm -f ${KERNEL_IMAGE_SYMLINK_NAME}.bin
> + ln -sf ${KERNEL_IMAGE_BASE_NAME}.bin ${KERNEL_IMAGE_SYMLINK_NAME}.bin
> + ln -sf ${KERNEL_IMAGE_BASE_NAME}.bin ${KERNEL_IMAGETYPE}
> + cd -
> install -m 0644 System.map ${D}/boot/System.map-${KERNEL_VERSION}
> install -m 0644 .config ${D}/boot/config-${KERNEL_VERSION}
> install -m 0644 vmlinux ${D}/boot/vmlinux-${KERNEL_VERSION}
This is going to break users who rely on the existing naming/layout.
The patch description is lacking on why we need to do this too, it just
says what you're doing and not why.
Cheers,
Richard
next prev parent reply other threads:[~2012-07-12 11:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 9:17 [PATCH] kernel.bbclass: update image name to keep it same in D and DEPLOYDIR b28495
2012-07-12 9:17 ` [PATCH] linux-dtb.inc: update dtb " b28495
2012-07-12 11:03 ` Richard Purdie
2012-07-15 11:07 ` Liu Ting-B28495
2012-07-16 22:23 ` McClintock Matthew-B29882
2012-07-12 11:02 ` Richard Purdie [this message]
2012-07-15 11:18 ` [PATCH] kernel.bbclass: update image " Liu Ting-B28495
2012-07-15 16:02 ` Khem Raj
2012-07-17 8:30 ` Liu Ting-B28495
2012-07-16 22:20 ` McClintock Matthew-B29882
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342090978.22262.7.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=b29882@freescale.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.