From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] intel: add prime interface for getting/setting a prime bo. Date: Sun, 15 Jul 2012 11:10:22 +0100 Message-ID: <1342347038_863@CP5-2952> References: <1342311766-30930-1-git-send-email-airlied@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 3FAE19E7A0 for ; Sun, 15 Jul 2012 03:10:46 -0700 (PDT) In-Reply-To: <1342311766-30930-1-git-send-email-airlied@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Dave Airlie , dri-devel@lists.freedesktop.org Cc: Dave Airlie List-Id: dri-devel@lists.freedesktop.org On Sun, 15 Jul 2012 10:22:46 +1000, Dave Airlie wrote: > This adds interfaces for the X driver to use to create a > prime handle from a buffer, and create a bo from a handle. > > Signed-off-by: Dave Airlie > --- > intel/intel_bufmgr.h | 4 ++++ > intel/intel_bufmgr_gem.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 50 insertions(+) > > diff --git a/intel/intel_bufmgr.h b/intel/intel_bufmgr.h > index 9b3a483..bf9ad5c 100644 > --- a/intel/intel_bufmgr.h > +++ b/intel/intel_bufmgr.h > @@ -192,6 +192,10 @@ void drm_intel_gem_context_destroy(drm_intel_context *ctx); > int drm_intel_gem_bo_context_exec(drm_intel_bo *bo, drm_intel_context *ctx, > int used, unsigned int flags); > > +int drm_intel_bufmgr_gem_set_bo_prime(drm_intel_bo *bo, int *prime_fd); > +drm_intel_bo *drm_intel_bufmgr_gem_get_bo_prime(drm_intel_bufmgr *bufmgr, > + int prime_fd, int size); I think drm_intel_bo_gem_create_for_prime(drm_intel_bufmgr *, int prime_fd, int size); drm_intel_bo_gem_export_to_prime(drm_intel_bo *, int *prime_fd); are more consistent names (with an alias for drm_intel_gem_bo_flink to drm_intel_bo_gem_export_to_name). Or possibly from_prime to be more in keeping with from_name, except the 'from' has the semantics of taking a copy and 'for' has the semantics of wrapping/proxying. At least in comparable API. However we are probably stuck with the existing semantics derived from drm_intel_bo_gem_create_from_name(). -Chris -- Chris Wilson, Intel Open Source Technology Centre