From: Joe Perches <joe@perches.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Hayes Wang <hayeswang@realtek.com>
Subject: Re: [PATCH net-next 0/2] Pull request for 'davem-next.r8169' branch
Date: Tue, 17 Jul 2012 15:46:41 -0700 [thread overview]
Message-ID: <1342565201.1898.6.camel@joe2Laptop> (raw)
In-Reply-To: <cover.1342562326.git.romieu@fr.zoreil.com>
On Wed, 2012-07-18 at 00:09 +0200, Francois Romieu wrote:
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
Hello Francois, just a bit of trivia:
> @@ -865,7 +865,8 @@ static bool rtl_loop_wait(struct rtl8169_private *tp, const struct rtl_cond *c,
> if (c->check(tp) == high)
> return true;
> }
> - netif_err(tp, drv, tp->dev, c->msg);
> + netif_err(tp, drv, tp->dev, "%s == %d (loop: %d, delay: %d).\n",
> + c->msg, !high, n, d);
Please avoid adding the period to a message before a newline.
$ git grep -E "[^\.]\\\\n\"" drivers/net/ethernet/realtek | wc -l
113
$ git grep -E "\.\\\\n\"" drivers/net/ethernet/realtek | wc -l
12
next prev parent reply other threads:[~2012-07-17 22:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 22:09 [PATCH net-next 0/2] Pull request for 'davem-next.r8169' branch Francois Romieu
2012-07-17 22:09 ` [PATCH net-next 1/2] r8169: remove rtl_ocpdr_cond Francois Romieu
2012-07-17 22:09 ` [PATCH net-next 2/2] r8169: verbose error message Francois Romieu
2012-07-17 22:46 ` Joe Perches [this message]
2012-07-18 16:11 ` [PATCH net-next 0/2] Pull request for 'davem-next.r8169' branch David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342565201.1898.6.camel@joe2Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.