Re: [PATCH] Remove the - between ${TARGET_PREFIX} and ar/nm for the env script, as this will make autotools look for arm-none-linux-gnueabi--ar instead of arm-none-linux-gnueabi-ar.

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2012-07-19 at 06:28 -0400, Robert P. J. Day wrote:
> On Thu, 19 Jul 2012, Richard Purdie wrote:
> 
> > On Thu, 2012-07-19 at 12:00 +0200, Martin Ertsaas wrote:
> > > Signed-off-by: Martin Ertsaas <mertsas@cisco.com>
> > > ---
> > >  meta/classes/toolchain-scripts.bbclass |    4 ++--
> > >  1 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/meta/classes/toolchain-scripts.bbclass b/meta/classes/toolchain-scripts.bbclass
> > > index bf37ec9..8f7c644 100644
> > > --- a/meta/classes/toolchain-scripts.bbclass
> > > +++ b/meta/classes/toolchain-scripts.bbclass
> > > @@ -68,8 +68,8 @@ toolchain_create_tree_env_script () {
> > >  	echo 'export RANLIB=${TARGET_PREFIX}ranlib' >> $script
> > >  	echo 'export OBJCOPY=${TARGET_PREFIX}objcopy' >> $script
> > >  	echo 'export OBJDUMP=${TARGET_PREFIX}objdump' >> $script
> > > -	echo 'export AR=${TARGET_PREFIX}-ar' >> $script
> > > -	echo 'export NM=${TARGET_PREFIX}-nm' >> $script
> > > +	echo 'export AR=${TARGET_PREFIX}ar' >> $script
> > > +	echo 'export NM=${TARGET_PREFIX}nm' >> $script
> > >  	echo 'export TARGET_PREFIX=${TARGET_PREFIX}' >> $script
> > >  	echo 'export CONFIGURE_FLAGS="--target=${TARGET_SYS} --host=${TARGET_SYS} --build=${BUILD_SYS} --with-libtool-sysroot=${STAGING_DIR_TARGET}"' >> $script
> > >  	if [ "${TARGET_OS}" = "darwin8" ]; then
> >
> > Merged to master, thanks.
> 
>   there appear to be more of those, based on a simple grep:
> 
> $ grep -rn "TARGET_PREFIX}-" *
> meta/classes/toolchain-scripts.bbclass:27:	echo 'export AR=${TARGET_PREFIX}-ar' >> $script
> meta/classes/toolchain-scripts.bbclass:28:	echo 'export NM=${TARGET_PREFIX}-nm' >> $script
> meta/classes/toolchain-scripts.bbclass:114:	echo 'export AR=${TARGET_PREFIX}-ar' >> $script
> meta/classes/toolchain-scripts.bbclass:115:	echo 'export NM=${TARGET_PREFIX}-nm' >> $script
> $
> 
>   just an observation.

Thanks, I've pushed something fixing those up too.

Cheers,

Richard