All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] package.bbclass: Create symlinks for packages with different packaged name
Date: Thu, 19 Jul 2012 15:43:01 +0100	[thread overview]
Message-ID: <1342708981.7940.14.camel@ted> (raw)
In-Reply-To: <1340871186-20545-1-git-send-email-andrei@gherzan.ro>

On Thu, 2012-06-28 at 11:13 +0300, Andrei Gherzan wrote:
> While generating license.manifest package information is searched in:
> filename=`ls ${TMPDIR}/pkgdata/*/runtime/${pkg}| head -1`
> This is ok as long as package name is the same as the package name
> after packaging.
> For example dbus is packaged as dbus-1. So, searching
> ls ${TMPDIR}/pkgdata/*/runtime/dbus-1 will fail because there is no file
> with this package name.
> 
> Signed-off-by: Andrei Gherzan <andrei@gherzan.ro>
> ---
>  meta/classes/package.bbclass |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
> index 10c2f0a..460b351 100644
> --- a/meta/classes/package.bbclass
> +++ b/meta/classes/package.bbclass
> @@ -1120,6 +1120,11 @@ python emit_pkgdata() {
>  		sf.write('%s_%s: %s\n' % ('PKGSIZE', pkg, get_directory_size(pkgdest + "/%s" % pkg)))
>  		sf.close()
>  
> +		# Symlinks needed while generating manifest
> +		pkgval = d.getVar('PKG_%s' % (pkg), True)
> +		if pkgval != pkg:
> +			subdata_sym = pkgdatadir + "/runtime/%s" % pkgval
> +			os.symlink(pkg,subdata_sym)
>  
>  		allow_empty = d.getVar('ALLOW_EMPTY_%s' % pkg, True)
>  		if not allow_empty:

I think this is the right idea, I'm just worried about having things in
the same directory. Could we do this but create the symlinks in a
"runtime-renamed" directory instead, then alter licence.bbclass to look
there?

Cheers,

Richard




  reply	other threads:[~2012-07-19 14:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-28  8:13 [PATCH] package.bbclass: Create symlinks for packages with different packaged name Andrei Gherzan
2012-07-19 14:43 ` Richard Purdie [this message]
2012-07-25 18:15   ` Andrei Gherzan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1342708981.7940.14.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.