From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Gruenbacher Date: Thu, 12 Dec 2013 20:07:54 +0100 (CET) Subject: [Cluster-devel] [PATCH 04/18] fs: add generic xattr_acl handlers In-Reply-To: <20131211104527.044064384@bombadil.infradead.org> References: <20131211104243.148113893@bombadil.infradead.org> <20131211104527.044064384@bombadil.infradead.org> Message-ID: <1342716144.69126.1386875274180.JavaMail.zimbra@linbit.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Christoph, > +static int > +posix_acl_xattr_set(struct dentry *dentry, const char *name, > + const void *value, size_t size, int flags, int type) > +{ > + struct inode *inode = dentry->d_inode; > + struct posix_acl *acl = NULL; > + int ret; > + > + if (!IS_POSIXACL(inode)) > + return -EOPNOTSUPP; > + if (S_ISLNK(inode->i_mode) || !inode->i_op->set_acl) > + return -EOPNOTSUPP; Sama here, I would remove the S_ISLNK() check. Andreas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zimbra13.linbit.com ([212.69.166.240]:55771 "EHLO zimbra13.linbit.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752053Ab3LLTHz (ORCPT ); Thu, 12 Dec 2013 14:07:55 -0500 Date: Thu, 12 Dec 2013 20:07:54 +0100 (CET) From: Andreas Gruenbacher To: Christoph Hellwig Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, Mark Fasheh , Joel Becker , reiserfs-devel@vger.kernel.org, xfs@oss.sgi.com, jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, Jan Kara Message-ID: <1342716144.69126.1386875274180.JavaMail.zimbra@linbit.com> In-Reply-To: <20131211104527.044064384@bombadil.infradead.org> References: <20131211104243.148113893@bombadil.infradead.org> <20131211104527.044064384@bombadil.infradead.org> Subject: Re: [PATCH 04/18] fs: add generic xattr_acl handlers MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-btrfs-owner@vger.kernel.org List-ID: Christoph, > +static int > +posix_acl_xattr_set(struct dentry *dentry, const char *name, > + const void *value, size_t size, int flags, int type) > +{ > + struct inode *inode = dentry->d_inode; > + struct posix_acl *acl = NULL; > + int ret; > + > + if (!IS_POSIXACL(inode)) > + return -EOPNOTSUPP; > + if (S_ISLNK(inode->i_mode) || !inode->i_op->set_acl) > + return -EOPNOTSUPP; Sama here, I would remove the S_ISLNK() check. Andreas From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Gruenbacher Subject: Re: [PATCH 04/18] fs: add generic xattr_acl handlers Date: Thu, 12 Dec 2013 20:07:54 +0100 (CET) Message-ID: <1342716144.69126.1386875274180.JavaMail.zimbra@linbit.com> References: <20131211104243.148113893@bombadil.infradead.org> <20131211104527.044064384@bombadil.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-btrfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-f2fs-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Mark Fasheh , Joel Becker , reiserfs-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, xfs-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org, jfs-discussion-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, cluster-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jan Kara To: Christoph Hellwig Return-path: In-Reply-To: <20131211104527.044064384-PfSpb0PWhxZc2C7mugBRk2EX/6BAtgUQ@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-ext4.vger.kernel.org Christoph, > +static int > +posix_acl_xattr_set(struct dentry *dentry, const char *name, > + const void *value, size_t size, int flags, int type) > +{ > + struct inode *inode = dentry->d_inode; > + struct posix_acl *acl = NULL; > + int ret; > + > + if (!IS_POSIXACL(inode)) > + return -EOPNOTSUPP; > + if (S_ISLNK(inode->i_mode) || !inode->i_op->set_acl) > + return -EOPNOTSUPP; Sama here, I would remove the S_ISLNK() check. Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from zimbra13.linbit.com ([212.69.166.240]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VrBcN-0006iI-8k for linux-mtd@lists.infradead.org; Thu, 12 Dec 2013 19:08:15 +0000 Date: Thu, 12 Dec 2013 20:07:54 +0100 (CET) From: Andreas Gruenbacher To: Christoph Hellwig Message-ID: <1342716144.69126.1386875274180.JavaMail.zimbra@linbit.com> In-Reply-To: <20131211104527.044064384@bombadil.infradead.org> References: <20131211104243.148113893@bombadil.infradead.org> <20131211104527.044064384@bombadil.infradead.org> Subject: Re: [PATCH 04/18] fs: add generic xattr_acl handlers MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: xfs@oss.sgi.com, Jan Kara , Mark Fasheh , reiserfs-devel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mtd@lists.infradead.org, viro@zeniv.linux.org.uk, jfs-discussion@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Joel Becker List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Christoph, > +static int > +posix_acl_xattr_set(struct dentry *dentry, const char *name, > + const void *value, size_t size, int flags, int type) > +{ > + struct inode *inode = dentry->d_inode; > + struct posix_acl *acl = NULL; > + int ret; > + > + if (!IS_POSIXACL(inode)) > + return -EOPNOTSUPP; > + if (S_ISLNK(inode->i_mode) || !inode->i_op->set_acl) > + return -EOPNOTSUPP; Sama here, I would remove the S_ISLNK() check. Andreas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 10D697F77 for ; Thu, 12 Dec 2013 13:08:00 -0600 (CST) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay3.corp.sgi.com (Postfix) with ESMTP id 930DBAC005 for ; Thu, 12 Dec 2013 11:07:56 -0800 (PST) Received: from zimbra13.linbit.com (zimbra13.linbit.com [212.69.166.240]) by cuda.sgi.com with ESMTP id opQlwMGfuTT9d0cC for ; Thu, 12 Dec 2013 11:07:55 -0800 (PST) Date: Thu, 12 Dec 2013 20:07:54 +0100 (CET) From: Andreas Gruenbacher Message-ID: <1342716144.69126.1386875274180.JavaMail.zimbra@linbit.com> In-Reply-To: <20131211104527.044064384@bombadil.infradead.org> References: <20131211104243.148113893@bombadil.infradead.org> <20131211104527.044064384@bombadil.infradead.org> Subject: Re: [PATCH 04/18] fs: add generic xattr_acl handlers MIME-Version: 1.0 List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com, Jan Kara , Mark Fasheh , reiserfs-devel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mtd@lists.infradead.org, viro@zeniv.linux.org.uk, jfs-discussion@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Joel Becker Christoph, > +static int > +posix_acl_xattr_set(struct dentry *dentry, const char *name, > + const void *value, size_t size, int flags, int type) > +{ > + struct inode *inode = dentry->d_inode; > + struct posix_acl *acl = NULL; > + int ret; > + > + if (!IS_POSIXACL(inode)) > + return -EOPNOTSUPP; > + if (S_ISLNK(inode->i_mode) || !inode->i_op->set_acl) > + return -EOPNOTSUPP; Sama here, I would remove the S_ISLNK() check. Andreas _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs