From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Sascha Hauer" <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re[2]: [PATCH 1/6] mc13xxx: Define maximum SPI clock frequency global to driver
Date: Fri, 20 Jul 2012 12:17:49 +0400 [thread overview]
Message-ID: <1342772269.79937327@f350.mail.ru> (raw)
In-Reply-To: <20120720081136.GQ30009@pengutronix.de>
Hello.
Fri, 20 Jul 2012 10:11:36 +0200 от Sascha Hauer <s.hauer@pengutronix.de>:
> On Fri, Jul 20, 2012 at 12:05:21PM +0400, Alexander Shiyan wrote:
> > >
> > > The values indeed look quite arbitrary, but it may be that a hardware
> > > design does not support such high frequencies. Maybe better
> > >
> > > if (!mc_dev->spi->max_speed_hz)
> > > mc_dev->spi->max_speed_hz = 20000000
> > >
> > > ?
> > On my opinion, tests for supported speed, is work for SPI-driver, not for device driver.
> > Is not it?
>
> So you mean that the i.MX spi drivers platform data should have a
> maximum speed field instead of the client drivers? Sounds good.
> In this case we can apply the patch.
No additional fields required. We are pass max_speed_hz option in the SPI-driver
to clock divider, so frequency cannot be higher than possible. Fixme.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-07-20 8:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 15:30 [PATCH 1/6] mc13xxx: Define maximum SPI clock frequency global to driver Alexander Shiyan
2012-07-19 15:30 ` [PATCH 2/6] i.MX: Removed unused declaration for imx_iim_get_mac Alexander Shiyan
2012-07-19 15:30 ` [PATCH 3/6] mc13xxx: Added dummy definition for mc13xxx_get() if CONFIG_MFD_MC13XXX is not set Alexander Shiyan
2012-07-19 17:56 ` Sascha Hauer
2012-07-20 8:08 ` Re[2]: " Alexander Shiyan
2012-07-19 15:30 ` [PATCH 4/6] tx51: Unused mc13xxx.h include removed Alexander Shiyan
2012-07-19 15:30 ` [PATCH 5/6] PCM970: Add MMC support Alexander Shiyan
2012-07-19 15:30 ` [PATCH 6/6] PCM038: Read UID from fuses and pass this value to kernel as serial number Alexander Shiyan
2012-07-19 18:12 ` Sascha Hauer
2012-07-19 18:48 ` Re[2]: " Alexander Shiyan
2012-07-19 18:49 ` Alexander Shiyan
2012-07-19 17:55 ` [PATCH 1/6] mc13xxx: Define maximum SPI clock frequency global to driver Sascha Hauer
2012-07-20 8:05 ` Re[2]: " Alexander Shiyan
2012-07-20 8:11 ` Sascha Hauer
2012-07-20 8:17 ` Alexander Shiyan [this message]
2012-07-20 7:46 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342772269.79937327@f350.mail.ru \
--to=shc_work@mail.ru \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.