All of lore.kernel.org
 help / color / mirror / Atom feed
From: benoit.canet@gmail.com
To: qemu-devel@nongnu.org
Cc: stefanha@gmail.com, stefanha@linux.vnet.ibm.com,
	"Benoît Canet" <benoit@irqsave.net>
Subject: [Qemu-devel] [PATCH 1/3] block: Add bdrv_have_block_jobs() so migration code abort if needed.
Date: Fri, 20 Jul 2012 21:32:35 +0200	[thread overview]
Message-ID: <1342812757-2651-2-git-send-email-benoit@irqsave.net> (raw)
In-Reply-To: <1342812757-2651-1-git-send-email-benoit@irqsave.net>

From: Benoît Canet <benoit@irqsave.net>

qmp_migrate() will be able to check if some block jobs are
running using bdrv_have_block_jobs() and abort safely if needed.

Signed-off-by: Benoit Canet <benoit@irqsave.net>
---
 block.c |   14 ++++++++++++++
 block.h |    2 ++
 2 files changed, 16 insertions(+)

diff --git a/block.c b/block.c
index ce7eb8f..2b7b999 100644
--- a/block.c
+++ b/block.c
@@ -4027,6 +4027,20 @@ out:
     return ret;
 }
 
+bool bdrv_have_block_jobs(void)
+{
+    BlockDriverState *bs;
+
+    QTAILQ_FOREACH(bs, &bdrv_states, list) {
+        if (bs->job || bdrv_in_use(bs)) {
+            return true;
+        }
+        bdrv_close(bs);
+    }
+
+    return false;
+}
+
 void *block_job_create(const BlockJobType *job_type, BlockDriverState *bs,
                        int64_t speed, BlockDriverCompletionFunc *cb,
                        void *opaque, Error **errp)
diff --git a/block.h b/block.h
index c89590d..1335a2b 100644
--- a/block.h
+++ b/block.h
@@ -337,6 +337,8 @@ void bdrv_disable_copy_on_read(BlockDriverState *bs);
 void bdrv_set_in_use(BlockDriverState *bs, int in_use);
 int bdrv_in_use(BlockDriverState *bs);
 
+bool bdrv_have_block_jobs(void);
+
 enum BlockAcctType {
     BDRV_ACCT_READ,
     BDRV_ACCT_WRITE,
-- 
1.7.9.5

  reply	other threads:[~2012-07-20 19:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-20 19:32 [Qemu-devel] [PATCH 0/3] Block migration when streaming block jobs are running benoit.canet
2012-07-20 19:32 ` benoit.canet [this message]
2012-07-23 10:02   ` [Qemu-devel] [PATCH 1/3] block: Add bdrv_have_block_jobs() so migration code abort if needed Paolo Bonzini
2012-07-23 10:25     ` Benoît Canet
2012-07-20 19:32 ` [Qemu-devel] [PATCH 2/3] qerror: Add error telling that streaming blocks migration benoit.canet
2012-07-20 19:32 ` [Qemu-devel] [PATCH 3/3] migration: block migration when streaming block jobs are running benoit.canet
2012-07-23  9:55   ` Stefan Hajnoczi
2012-07-23 10:17     ` Benoît Canet
2012-07-23 10:43       ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1342812757-2651-2-git-send-email-benoit@irqsave.net \
    --to=benoit.canet@gmail.com \
    --cc=benoit@irqsave.net \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.