From: Shuah Khan <shuah.khan@hp.com>
To: David Miller <davem@davemloft.net>
Cc: mcarlson@broadcom.com, bhutchings@solarflare.com,
eric.dumazet@gmail.com, mchan@broadcom.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH RFT] net: Fix Neptune ethernet driver to check dma mapping error
Date: Fri, 20 Jul 2012 15:36:37 -0600 [thread overview]
Message-ID: <1342820197.5434.54.camel@lorien2> (raw)
In-Reply-To: <20120720.143005.135422510157595877.davem@davemloft.net>
On Fri, 2012-07-20 at 14:30 -0700, David Miller wrote:
> From: Shuah Khan <shuah.khan@hp.com>
> Date: Fri, 20 Jul 2012 15:27:59 -0600
>
> > Request for testing, since I don't have the hardware to test.
>
> This is not how you post a patch.
>
> > --------------------------------------------------------------------
>
> When you put those "---..." there, GIT is going to eliminate everything
> afterwards from the commit mesage when I apply this. Yet afterwards
> is what your commit message actually is.
>
> You therefore should do things the other way around, provide the commit
> message text, then the "---..." line, then your comments you don't want
> in the final commit message.
Thanks. I had it reversed in my head for some reason. Maybe not enough
coffee :) Will resend the patch now.
-- Shuah
prev parent reply other threads:[~2012-07-20 21:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 21:27 [PATCH RFT] net: Fix Neptune ethernet driver to check dma mapping error Shuah Khan
2012-07-20 21:30 ` David Miller
2012-07-20 21:36 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342820197.5434.54.camel@lorien2 \
--to=shuah.khan@hp.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.