All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Cc: Zhenfeng.Zhao@windriver.com
Subject: Re: [PATCH 2/2] createrepo 0.4.11: fix the RDEPENDS
Date: Sun, 22 Jul 2012 11:37:58 +0100	[thread overview]
Message-ID: <1342953478.21788.63.camel@ted> (raw)
In-Reply-To: <5009F538.6090007@linux.intel.com>

On Fri, 2012-07-20 at 17:18 -0700, Saul Wold wrote:
> On 07/20/2012 02:49 AM, Robert Yang wrote:
> > The libxml2-native and rpm-native should be ready before createrepo
> > runs since it needs "import libxml2 rpm".
> >
> > The target createrepo needs libxml2-python when run, but the libxml2
> > doesn't generate the python module (disabled). We may need to fix it
> > or rename the recipe to createrepo-native_0.4.11.bb.
> >
> > This recipe is only for the rpm backend system.
> >
> > [YOCTO #2753]
> >
> > Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> > ---
> >   .../createrepo/createrepo_0.4.11.bb                |    4 +++-
> >   1 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/meta/recipes-support/createrepo/createrepo_0.4.11.bb b/meta/recipes-support/createrepo/createrepo_0.4.11.bb
> > index 060ed59..7a4d059 100644
> > --- a/meta/recipes-support/createrepo/createrepo_0.4.11.bb
> > +++ b/meta/recipes-support/createrepo/createrepo_0.4.11.bb
> > @@ -4,7 +4,9 @@ HOMEPAGE = "http://createrepo.baseurl.org/"
> >   LICENSE = "GPLv2+"
> >   LIC_FILES_CHKSUM = "file://COPYING;md5=18810669f13b87348459e611d31ab760"
> >
> > -PR = "r3"
> > +RDEPENDS_${PN}_virtclass-native += "libxml2-native rpm-native"
> > +
> This should not be required here since the package_rpm.bbclass contains 
> a line:
> PACKAGEINDEXDEPS += "rpm-native:do_populate_sysroot"
> 
> We might need to add libxml2-native to the PACKAGEINDEXDEPS

FWIW, having correct RDEPENDS in the recipes is important so this fix is
a good one regardless of whether it fixes the other issue or not.

Cheers,

Richard




  reply	other threads:[~2012-07-22 10:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-20  9:49 [PATCH 0/2] package_rpm and createrepo fixes Robert Yang
2012-07-20  9:49 ` [PATCH 1/2] package_rpm: DEPLOY_DIR_RPM must exist before make index Robert Yang
2012-07-20  9:49 ` [PATCH 2/2] createrepo 0.4.11: fix the RDEPENDS Robert Yang
2012-07-21  0:18   ` Saul Wold
2012-07-22 10:37     ` Richard Purdie [this message]
2012-07-23  2:21     ` Robert Yang
2012-07-21  0:19 ` [PATCH 0/2] package_rpm and createrepo fixes Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1342953478.21788.63.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=Zhenfeng.Zhao@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.