Re: [PATCH 03/10] fdisk: API: add fdisk_label_change

[Davidlohr Bueso <dave@gnu.org>]

On Tue, 2012-07-24 at 12:32 +0200, Bernhard Voelker wrote:
> 
> On 07/24/2012 11:56 AM, Petr Uzel wrote:
> > On Tue, Jul 24, 2012 at 11:47:53AM +0200, Bernhard Voelker wrote:
> >>
> >>
> >> On 07/22/2012 07:05 PM, Davidlohr Bueso wrote:
> >>> --- a/fdisks/fdisksunlabel.c
> >>> +++ b/fdisks/fdisksunlabel.c
> >>> @@ -161,6 +161,7 @@ void create_sunlabel(struct fdisk_context *cxt)
> >>>  
> >>>  	init();
> >>>  	fdisk_mbr_zeroize(cxt);
> >>> +	fdisk_label_change(cxt, "sun");
> >>>  
> >>
> 
> >>
> >> Shouldn't we use something else than hardcoded "sun"|"dos"|"sgi"|...
> >> strings here? 
> > 
> > What's the problem with these strings? I think these are well
> > recognized with clear meaning. What alternative do you propose?
> 
> Sorry, I should've proposed this already in my first mail:
> 
> -	fdisk_label_change(cxt, "sun");
> +	fdisk_label_change(cxt, sun_label.name);
> 

I'm planning on adding the disklabel type (numeric) to the context
structure in a near future, so we'd then have two ways of identifying
labels. I really do not see much difference between numbers and strings
- this is not a performance critical program.

Thanks,
Davidlohr

> It's already defined ;-)
> 
> Have a nice day,
> Berny
> 
> --
> To unsubscribe from this list: send the line "unsubscribe util-linux" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>