Re: [PATCH v2] libxl: libxl_domain_sched_params_set case for ARINC 653 scheduler

[Dario Faggioli <raistlin@linux.it>]

[-- Attachment #1.1: Type: text/plain, Size: 1609 bytes --]

On Wed, 2012-07-25 at 11:42 -0400, Andrew Kane wrote: 
> Implements sched_arinc653_domain_set to match the existing API. Currently,
> there is no domain-specific configuration when using the ARINC 653 scheduler,
> so we simply return success.
> 
> Signed-off-by: Andrew Kane <Andrew.Kane@dornerworks.com>
> 
Hi again Andrew,

> static int sched_credit_domain_get(libxl__gc *gc, uint32_t domid,
>                                     libxl_domain_sched_params *scinfo)
>  {
> @@ -3909,6 +3917,9 @@ int libxl_domain_sched_params_set(libxl_
>      case LIBXL_SCHEDULER_CREDIT2:
>          ret=sched_credit2_domain_set(gc, domid, scinfo);
>          break;
> +    case LIBXL_SCHEDULER_ARINC653:
> +        ret=sched_arinc653_domain_set(gc, domid, scinfo);
> +        break;
>      default:
>          LOG(ERROR, "Unknown scheduler");
>          ret=ERROR_INVAL;
>
I don't know if you've seen it, as I said it in my second e-mail, while
replying to you, so I'm asking here again. Is it ok that you need to do
this for libxl_domain_sched_params_set() bit *NOT* for
libxl_domain_sched_params_get()? If it is, sorry for bothering... If
not, you probably should add that too. :-)

To me it seems it could be needed, but it might well be me not knowing
enough of ARINC's interface. :-P

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)



[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel