From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: image.bbclass: Update outdated reference to "export IMAGE_BASENAME"
Date: Fri, 27 Jul 2012 12:25:04 +0100 [thread overview]
Message-ID: <1343388304.9574.118.camel@ted> (raw)
In-Reply-To: <alpine.DEB.2.02.1207261904590.18831@oneiric>
On Thu, 2012-07-26 at 19:06 -0400, Robert P. J. Day wrote:
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> ---
>
> does this look about right?
>
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 1799bf1..b0b476f 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -58,10 +58,9 @@ PACKAGE_GROUP_dev-pkgs[optional] = "1"
> PACKAGE_GROUP_doc-pkgs = "${@' '.join('%s-doc' % pkg for pkg in normal_pkgs_to_install(d))}"
> PACKAGE_GROUP_doc-pkgs[optional] = "1"
>
> -# "export IMAGE_BASENAME" not supported at this time
> IMAGE_INSTALL ?= ""
> IMAGE_INSTALL[type] = "list"
> -IMAGE_BASENAME[export] = "1"
> +export IMAGE_BASENAME
> export PACKAGE_INSTALL ?= "${IMAGE_INSTALL} ${ROOTFS_BOOTSTRAP_INSTALL} ${FEATURE_INSTALL}"
> PACKAGE_INSTALL_ATTEMPTONLY ?= "${FEATURE_INSTALL_OPTIONAL}"
>
> diff --git a/meta/recipes-core/images/core-image-minimal-initramfs.bb b/meta/recipes-core/images/core-image-minimal-initramfs.bb
> index 7f6826c..ddc2142 100644
> --- a/meta/recipes-core/images/core-image-minimal-initramfs.bb
> +++ b/meta/recipes-core/images/core-image-minimal-initramfs.bb
> @@ -8,7 +8,6 @@ IMAGE_INSTALL = "initramfs-live-boot initramfs-live-install initramfs-live-insta
> # Do not pollute the initrd image with rootfs features
> IMAGE_FEATURES = ""
>
> -export IMAGE_BASENAME = "core-image-minimal-initramfs"
> IMAGE_LINGUAS = ""
I meant just to remove the export flag here, so:
-export IMAGE_BASENAME = "core-image-minimal-initramfs"
+IMAGE_BASENAME = "core-image-minimal-initramfs"
Cheers,
Richard
next prev parent reply other threads:[~2012-07-27 11:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 23:06 image.bbclass: Update outdated reference to "export IMAGE_BASENAME" Robert P. J. Day
2012-07-27 11:25 ` Richard Purdie [this message]
2012-07-27 12:01 ` Andrea Adami
2012-07-27 12:01 ` Robert P. J. Day
2012-07-27 12:53 ` Andrea Adami
2012-07-27 13:09 ` Robert P. J. Day
2012-07-27 13:15 ` Richard Purdie
2012-07-27 15:57 ` Andrea Adami
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343388304.9574.118.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.