All of lore.kernel.org
 help / color / mirror / Atom feed
From: Axel Lin <axel.lin@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lrg@ti.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: core: Add intermediate cast to uintptr_t before casting to pointer
Date: Tue, 31 Jul 2012 10:21:56 +0800	[thread overview]
Message-ID: <1343701316.7557.1.camel@phoenix> (raw)
In-Reply-To: <20120730153309.GK4468@opensource.wolfsonmicro.com>

於 一，2012-07-30 於 16:33 +0100，Mark Brown 提到：
> On Mon, Jul 30, 2012 at 07:47:13AM +0800, Axel Lin wrote:
> 
> >  		_notifier_call_chain(rdev, REGULATOR_EVENT_VOLTAGE_CHANGE,
> > -				     (void *)best_val);
> > +				     (void *)(uintptr_t)best_val);
> 
> This also looks problematic, you should never need to cast a pointer to
> or from void.

If I remove the cast to (void *), I got below build warning:

  CC      drivers/regulator/core.o
drivers/regulator/core.c: In function '_regulator_do_set_voltage':
drivers/regulator/core.c:2183:10: warning: passing argument 3 of
'_notifier_call_chain' makes pointer from integer without a cast
[enabled by default]
drivers/regulator/core.c:94:13: note: expected 'void *' but argument is
of type 'long unsigned int'

( Sorry, I forgot to reply-all so I send the mail again )
Axel


  reply	other threads:[~2012-07-31  2:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-29 23:47 [PATCH] regulator: core: Add intermediate cast to uintptr_t before casting to pointer Axel Lin
2012-07-30 15:33 ` Mark Brown
2012-07-31  2:21   ` Axel Lin [this message]
2012-07-31 15:41     ` Mark Brown
2012-07-31 16:08       ` Axel Lin
2012-08-02 18:00         ` Mark Brown
2012-08-05 16:10           ` Axel Lin
2012-08-06 14:31             ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343701316.7557.1.camel@phoenix \
    --to=axel.lin@gmail.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.