From: Chris Wilson <chris@chris-wilson.co.uk>
To: "Xu, Anhua" <anhua.xu@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: Find bugs in i915 driver
Date: Tue, 31 Jul 2012 08:57:36 +0100 [thread overview]
Message-ID: <1343721467_20698@CP5-2952> (raw)
In-Reply-To: <D908B1B9E708C047A32444772B58AE88212DC1@SHSMSX101.ccr.corp.intel.com>
On Tue, 31 Jul 2012 02:29:01 +0000, "Xu, Anhua" <anhua.xu@intel.com> wrote:
> Hi, I found some bugs in i915 driver when reviewing intel_display.c The parameter passed-in for function hdmi/adpa/lvds_pipe_enabled() are not coherent with functions' definition.
> This is the patch.
Patch looks good, you might want to mention that the regression was
introduced with commit 1519b9956eb4b4180fa3f47c73341463cdcfaa37.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-07-31 7:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 2:29 Find bugs in i915 driver Xu, Anhua
2012-07-31 7:57 ` Chris Wilson [this message]
2012-07-31 9:17 ` Xu, Anhua
2012-07-31 14:23 ` Greg KH
2012-08-01 9:31 ` Paul Menzel
2012-08-10 11:41 ` Daniel Vetter
2012-08-13 3:08 ` Xu, Anhua
2012-08-13 7:10 ` Paul Menzel
2012-08-13 8:07 ` Xu, Anhua
2012-08-21 7:20 ` Daniel Vetter
2012-08-22 8:38 ` Daniel Vetter
2012-08-13 7:52 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343721467_20698@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=anhua.xu@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.