From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] package_rpm.bbclass: Accomodate dash when using arrays
Date: Tue, 31 Jul 2012 12:22:32 +0100 [thread overview]
Message-ID: <1343733752.9756.1.camel@ted> (raw)
In-Reply-To: <1343597225-9805-1-git-send-email-raj.khem@gmail.com>
On Sun, 2012-07-29 at 14:27 -0700, Khem Raj wrote:
> we were assigning local variable to an array coming through
> positional arguments. local is a non posix contruct thats
> also supported by dash luckily but operates differently in this
> case it exapnds the array before assignment. so
>
> local pkgs="$@"
>
> turns into pkgs=locale-base-en-us locale-base-en-gb
>
> ant we see errors
>
> run.do_rootfs.25593: 932: local: locale-base-en-gb: bad variable name
>
> So lets not use defining and assigning local in one go
> first define a local and then the assignment
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta/classes/package_rpm.bbclass | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
Merged to master, thanks.
Richard
prev parent reply other threads:[~2012-07-31 11:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-29 21:27 [PATCH] package_rpm.bbclass: Accomodate dash when using arrays Khem Raj
2012-07-30 9:26 ` Paul Eggleton
2012-07-30 15:27 ` Khem Raj
2012-07-31 11:22 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343733752.9756.1.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.